Skip to content

Commit 1acf90d

Browse files
committed
remove deprecated 'bardir' attribute (replaced by 'orientation')
1 parent d5d3712 commit 1acf90d

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

src/plot_api/helpers.js

-11
Original file line numberDiff line numberDiff line change
@@ -295,17 +295,6 @@ exports.cleanData = function(data) {
295295
delete trace.error_y.opacity;
296296
}
297297

298-
// convert bardir to orientation, and put the data into
299-
// the axes it's eventually going to be used with
300-
if('bardir' in trace) {
301-
if(trace.bardir === 'h' && (traceIs(trace, 'bar') ||
302-
trace.type.substr(0, 9) === 'histogram')) {
303-
trace.orientation = 'h';
304-
exports.swapXYData(trace);
305-
}
306-
delete trace.bardir;
307-
}
308-
309298
// now we have only one 1D histogram type, and whether
310299
// it uses x or y data depends on trace.orientation
311300
if(trace.type === 'histogramy') exports.swapXYData(trace);

src/traces/bar/attributes.js

-9
Original file line numberDiff line numberDiff line change
@@ -227,13 +227,4 @@ module.exports = {
227227
editType: 'style'
228228
},
229229
zorder: scatterAttrs.zorder,
230-
231-
_deprecated: {
232-
bardir: {
233-
valType: 'enumerated',
234-
editType: 'calc',
235-
values: ['v', 'h'],
236-
description: 'Renamed to `orientation`.'
237-
}
238-
}
239230
};

src/traces/histogram/attributes.js

-4
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,5 @@ module.exports = {
246246
selected: barAttrs.selected,
247247
unselected: barAttrs.unselected,
248248

249-
_deprecated: {
250-
bardir: barAttrs._deprecated.bardir
251-
},
252-
253249
zorder: barAttrs.zorder
254250
};

0 commit comments

Comments
 (0)