Skip to content

Commit 1a9f640

Browse files
committed
Remove unexposed cascade option
1 parent 4a1c617 commit 1a9f640

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/components/drawing/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ drawing.translatePoints = function(s, xa, ya, trace, transitionConfig, joinDirec
6969
var trans;
7070
if(!joinDirection) {
7171
trans = p.transition()
72-
.delay(transitionConfig.delay + transitionConfig.cascade / size * i)
72+
.delay(transitionConfig.delay)
7373
.duration(transitionConfig.duration)
7474
.ease(transitionConfig.ease)
7575
.attr('transform', 'translate(' + x + ',' + y + ')');

src/plot_api/plot_api.js

+9-4
Original file line numberDiff line numberDiff line change
@@ -2652,7 +2652,7 @@ Plotly.transition = function(gd, data, layout, traceIndices, transitionConfig) {
26522652
basePlotModules[j].plot(gd, transitionedTraces, traceTransitionConfig);
26532653
}
26542654

2655-
gd._transitionData._completionTimeout = setTimeout(completeTransition, transitionConfig.duration + transitionConfig.delay);
2655+
gd._transitionData._completionTimeout = setTimeout(completeTransition, transitionConfig.duration + transitionConfig.delay + 1000);
26562656

26572657
if(!hasAxisTransition && !hasTraceTransition) {
26582658
return false;
@@ -2662,9 +2662,14 @@ Plotly.transition = function(gd, data, layout, traceIndices, transitionConfig) {
26622662
function completeTransition() {
26632663
flushCallbacks(gd._transitionData._interruptCallbacks);
26642664

2665-
gd.emit('plotly_endtransition', []);
2666-
2667-
return executeCallbacks(gd._transitionData._cleanupCallbacks);
2665+
return Promise.resolve().then(function () {
2666+
if (transitionConfig.redraw) {
2667+
return Plotly.redraw(gd);
2668+
}
2669+
}).then(function () {
2670+
gd.emit('plotly_endtransition', []);
2671+
return executeCallbacks(gd._transitionData._cleanupCallbacks);
2672+
});
26682673
}
26692674

26702675
function interruptPreviousTransitions() {

0 commit comments

Comments
 (0)