Skip to content

Commit 19e60be

Browse files
authored
Merge pull request #3907 from plotly/sunburst-inscribed-radius-fix
Fix sunburst text in sectors centered around theta=180
2 parents 7a7a3f8 + 67ccce0 commit 19e60be

File tree

3 files changed

+87
-1
lines changed

3 files changed

+87
-1
lines changed

Diff for: src/traces/sunburst/plot.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ function determineInsideTextFont(trace, pt, layoutFont) {
797797
}
798798

799799
function getInscribedRadiusFraction(pt) {
800-
if(pt.rpx0 === 0 && pt.xmid === Math.PI) {
800+
if(pt.rpx0 === 0 && Lib.isFullCircle([pt.x0, pt.x1])) {
801801
// special case of 100% with no hole
802802
return 1;
803803
} else {

Diff for: test/image/baselines/sunburst_textfit.png

60.7 KB
Loading

Diff for: test/image/mocks/sunburst_textfit.json

+86
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
{
2+
"data": [
3+
{
4+
"type": "sunburst",
5+
"ids": [
6+
"Parent Name One",
7+
"Parent Name Two",
8+
"Parent Name Three",
9+
"Parent Name Four",
10+
"Parent Name Five",
11+
"Parent Name Six",
12+
"Parent Name Seven",
13+
"Parent Name One-Child 1",
14+
"Parent Name Two-Child 2",
15+
"Parent Name Two-Child 3",
16+
"Parent Name Two-Child 4",
17+
"Parent Name Two-Child 5",
18+
"Parent Name Three-Child 6",
19+
"Parent Name Three-Child 7",
20+
"Parent Name Four-Child 8",
21+
"Parent Name Four-Child 9",
22+
"Parent Name Five-Child 10",
23+
"Parent Name Five-Child 11",
24+
"Parent Name Five-Child 12",
25+
"Parent Name Six-Child 13",
26+
"Parent Name Six-Child 14",
27+
"Parent Name Seven-Child 15",
28+
"Parent Name Seven-Child 16",
29+
"Parent Name Seven-Child 17"
30+
],
31+
"labels": [
32+
"Parent Name One",
33+
"Parent Name Two",
34+
"Parent Name Three",
35+
"Parent Name Four",
36+
"Parent Name Five",
37+
"Parent Name Six",
38+
"Parent Name Seven",
39+
"Child 1",
40+
"Child 2",
41+
"Child 3",
42+
"Child 4",
43+
"Child 5",
44+
"Child 6",
45+
"Child 7",
46+
"Child 8",
47+
"Child 9",
48+
"Child 10",
49+
"Child 11",
50+
"Child 12",
51+
"Child 13",
52+
"Child 14",
53+
"Child 15",
54+
"Child 16",
55+
"Child 17"
56+
],
57+
"parents": [
58+
"",
59+
"",
60+
"",
61+
"",
62+
"",
63+
"",
64+
"",
65+
"Parent Name One",
66+
"Parent Name Two",
67+
"Parent Name Two",
68+
"Parent Name Two",
69+
"Parent Name Two",
70+
"Parent Name Three",
71+
"Parent Name Three",
72+
"Parent Name Four",
73+
"Parent Name Four",
74+
"Parent Name Five",
75+
"Parent Name Five",
76+
"Parent Name Five",
77+
"Parent Name Six",
78+
"Parent Name Six",
79+
"Parent Name Seven",
80+
"Parent Name Seven",
81+
"Parent Name Seven"
82+
]
83+
}
84+
],
85+
"layout": {}
86+
}

0 commit comments

Comments
 (0)