Skip to content

Commit 18ec98e

Browse files
authored
Merge pull request #5458 from plotly/fix5457-duplicate-keys
Avoid duplicate keys in plotly builds
2 parents ddf8f66 + 734c61a commit 18ec98e

File tree

3 files changed

+7
-243
lines changed

3 files changed

+7
-243
lines changed

.circleci/config.yml

+3
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ jobs:
169169
- run:
170170
name: Test plotly bundles againt unexpected characters
171171
command: npm run no-bad-char
172+
- run:
173+
name: Test plotly bundles againt duplicate keys
174+
command: npm run no-dup-keys
172175
- run:
173176
name: Test certain bundles against function constructors
174177
command: npm run no-new-func

package-lock.json

+3-243
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"lint-fix": "eslint . --fix || true",
3434
"no-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: error}' $(find dist -type f -iname '*.js' | grep -v plotly-gl* | grep -v plotly-with-meta.* | grep -v plotly.js | grep -v plotly.min.js | grep -v MathJax.js)",
3535
"no-bad-char": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-misleading-character-class: error}' $(find dist -type f -iname '*.js' | grep plotly)",
36+
"no-dup-keys": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-dupe-keys: error}' $(find dist -type f -iname '*.js' | grep plotly)",
3637
"docker": "node tasks/docker.js",
3738
"pretest": "node tasks/pretest.js",
3839
"test-jasmine": "karma start test/jasmine/karma.conf.js",

0 commit comments

Comments
 (0)