Skip to content

Commit 18e19a8

Browse files
authored
Merge pull request #2556 from plotly/bump-line2d
Bump line2d
2 parents fab0cf1 + 3152dec commit 18e19a8

File tree

6 files changed

+72
-18
lines changed

6 files changed

+72
-18
lines changed

package-lock.json

+59-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"polybooljs": "^1.2.0",
100100
"regl": "^1.3.1",
101101
"regl-error2d": "^2.0.3",
102-
"regl-line2d": "^2.1.5",
102+
"regl-line2d": "^3.0.1",
103103
"regl-scatter2d": "^3.0.0",
104104
"right-now": "^1.0.0",
105105
"robust-orientation": "^1.1.3",

src/traces/scattergl/convert.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ function convertStyle(gd, trace) {
2727
var i;
2828

2929
var opts = {
30-
marker: null,
31-
line: null,
32-
fill: null,
33-
errorX: null,
34-
errorY: null,
35-
selected: null,
36-
unselected: null
30+
marker: undefined,
31+
line: undefined,
32+
fill: undefined,
33+
errorX: undefined,
34+
errorY: undefined,
35+
selected: undefined,
36+
unselected: undefined
3737
};
3838

3939
if(trace.visible !== true) return opts;

src/traces/scattergl/index.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ function calc(gd, trace) {
121121
scene.count++;
122122

123123
// stash scene ref
124-
stash.scene = scene;
124+
stash._scene = scene;
125125
stash.index = scene.count - 1;
126126
stash.x = x;
127127
stash.y = y;
@@ -326,7 +326,7 @@ function plot(gd, subplot, cdata) {
326326
if(!cdata.length) return;
327327

328328
var fullLayout = gd._fullLayout;
329-
var scene = cdata[0][0].t.scene;
329+
var scene = cdata[0][0].t._scene;
330330
var dragmode = fullLayout.dragmode;
331331

332332
// we may have more subplots than initialized data due to Axes.getSubplots method
@@ -760,7 +760,7 @@ function selectPoints(searchInfo, polygon) {
760760
var stash = cd[0].t;
761761
var x = stash.x;
762762
var y = stash.y;
763-
var scene = stash.scene;
763+
var scene = stash._scene;
764764

765765
if(!scene) return selection;
766766

@@ -816,7 +816,7 @@ function selectPoints(searchInfo, polygon) {
816816
function style(gd, cd) {
817817
if(cd) {
818818
var stash = cd[0].t;
819-
var scene = stash.scene;
819+
var scene = stash._scene;
820820
scene.clear();
821821
scene.draw();
822822
}

src/traces/scatterpolargl/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ function plot(container, subplot, cdata) {
131131
scene.count = cdata.length;
132132

133133
// stash scene ref
134-
stash.scene = scene;
134+
stash._scene = scene;
135135
stash.index = traceIndex;
136136
stash.x = x;
137137
stash.y = y;
603 Bytes
Loading

0 commit comments

Comments
 (0)