Merge pull request #3874 from plotly/sane-topojson-v3

Use sane-topojson v3

Author: etpinard

dist/topojson/africa_110m.json

@@ -107,7 +107,7 @@
     "regl-splom": "^1.0.6",
     "right-now": "^1.0.0",
     "robust-orientation": "^1.1.3",
-    "sane-topojson": "^2.0.0",
+    "sane-topojson": "^3.0.1",
     "strongly-connected-components": "^1.0.1",
     "superscript-text": "^1.0.0",
     "svg-path-sdf": "^1.1.3",

dist/topojson/africa_50m.json

@@ -42,21 +42,16 @@ function locationToFeature(locationmode, location, features) {
 
     if(locationId) {
         if(locationmode === 'USA-states') {
-            // Filter out features south of the equator
+            // Filter out features out in USA
             //
             // This is important as the Natural Earth files
             // include state/provinces from USA, Canada, Australia and Brazil
             // which have some overlay in their two-letter ids. For example,
             // 'WA' is used for both Washington state and Western Australia.
-            // As subunits from USA and Canada never conflict, filtering out features
-            // south of the equator suffices to fix https://github.com/plotly/plotly.js/issues/3779
-            //
-            // A better fix would have us add a "governing unit" properties in subunit features
-            // in the `sane-topojson` package to avoid conflicts.
             features2 = [];
             for(i = 0; i < features.length; i++) {
                 f = features[i];
-                if(f.properties && f.properties.ct && f.properties.ct[1] > 0) {
+                if(f.properties && f.properties.gu && f.properties.gu === 'USA') {
                     features2.push(f);
                 }
             }

dist/topojson/asia_110m.json

@@ -8,9 +8,20 @@ var pathToImageTest = path.join(pathToRoot, 'test/image');
 var pathToDist = path.join(pathToRoot, 'dist/');
 var pathToBuild = path.join(pathToRoot, 'build/');
 
-var pathToTopojsonSrc = path.join(
-    path.dirname(require.resolve('sane-topojson')), 'dist/'
-);
+var pathToTopojsonSrc;
+try {
+    pathToTopojsonSrc = path.join(path.dirname(require.resolve('sane-topojson')), 'dist/');
+} catch(e) {
+    console.log([
+        '',
+        'WARN: Cannot resolve path to *sane-topojson* package.',
+        '  This can happen when one `npm link sane-topojson`',
+        '  and runs a command in a Docker container.',
+        '  There is nothing to worry, if you see this warning while running',
+        '  `npm run test-image`, `npm run test-export` or `npm run baseline` ;)',
+        ''
+    ].join('\n'));
+}
 
 var partialBundleNames = [
     'basic', 'cartesian', 'geo', 'gl3d', 'gl2d', 'mapbox', 'finance'