Skip to content

Commit 1634ec8

Browse files
committed
make q1 hover label have higher "priority" than min
... so that if the min and q1 overlap and have the same overlap key-function output, q1 will be rendered, not min
1 parent a4b771c commit 1634ec8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/traces/box/hover.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ function hoverOnBoxes(pointData, xval, yval, hovermode) {
151151

152152
// box plots: each "point" gets many labels
153153
var usedVals = {};
154-
var attrs = ['med', 'min', 'q1', 'q3', 'max'];
154+
var attrs = ['med', 'q1', 'q3', 'min', 'max'];
155155

156156
if(trace.boxmean || (trace.meanline || {}).visible) {
157157
attrs.push('mean');

test/jasmine/tests/box_test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,8 @@ describe('Test box hover:', function() {
274274
return fig;
275275
},
276276
nums: [
277-
'q1: 0.3', 'median: 0.45', 'q3: 0.6', 'max: 1', 'median: 0.55', 'min: 0', 'min: 0.2',
278-
'q3: 0.6', 'max: 0.7', 'median: 0.45', 'min: 0.1', 'q3: 0.6', 'max: 0.9'
277+
'q1: 0.3', 'median: 0.45', 'q3: 0.6', 'max: 1', 'median: 0.55', 'min: 0', 'q1: 0.1',
278+
'q3: 0.6', 'max: 0.7', 'median: 0.45', 'q1: 0.2', 'q3: 0.6', 'max: 0.9'
279279
],
280280
name: [
281281
'', 'kale', '', '', 'radishes', '', '',
@@ -453,7 +453,7 @@ describe('Test box hover:', function() {
453453
}
454454
},
455455
pos: [200, 200],
456-
nums: ['median: 2', 'min: 1', 'q3: 2.5'],
456+
nums: ['median: 2', 'q1: 1.5', 'q3: 2.5'],
457457
name: ['', '', ''],
458458
axis: 'trace 0'
459459
}].forEach(function(specs) {

test/jasmine/tests/violin_test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -388,8 +388,8 @@ describe('Test violin hover:', function() {
388388
},
389389
nums: [
390390
'q3: 0.6', 'median: 0.45', 'q3: 0.6', 'max: 1', 'y: 0.9266848, kde: 0.383',
391-
'median: 0.55', 'min: 0', 'q1: 0.3', 'min: 0.2', 'max: 0.7', 'y: 0.9266848, kde: 0.182',
392-
'median: 0.45', 'min: 0.1', 'q3: 0.6', 'max: 0.9', 'y: 0.9266848, kde: 0.435'
391+
'median: 0.55', 'min: 0', 'q1: 0.3', 'q1: 0.2', 'max: 0.7', 'y: 0.9266848, kde: 0.182',
392+
'median: 0.45', 'q1: 0.1', 'q3: 0.6', 'max: 0.9', 'y: 0.9266848, kde: 0.435'
393393
],
394394
name: [
395395
'', 'kale', '', '', '', 'radishes', '', '', '', '',
@@ -535,7 +535,7 @@ describe('Test violin hover:', function() {
535535
name: ['', '', '', '', '', ''],
536536
axis: 'Sat',
537537
hoverLabelPos: [
538-
[364, 270], [339, 270], [352, 270],
538+
[364, 270], [352, 270], [339, 270],
539539
[346, 270], [349, 270], [387, 270]
540540
]
541541
}, {

0 commit comments

Comments
 (0)