Skip to content

Commit 15dc324

Browse files
committed
add pointNumber to sankey event data
1 parent 69de548 commit 15dc324

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

src/traces/sankey/render.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,15 @@ function sankeyModel(layout, d, i) {
8686

8787
var nodes = nodeSpec.label.map(function(l, i) {
8888
return {
89+
pointNumber: i,
8990
label: l,
9091
color: Lib.isArray(nodeSpec.color) ? nodeSpec.color[i] : nodeSpec.color
9192
};
9293
});
9394

9495
var links = linkSpec.value.map(function(d, i) {
9596
return {
97+
pointNumber: i,
9698
label: linkSpec.label[i],
9799
color: Lib.isArray(linkSpec.color) ? linkSpec.color[i] : linkSpec.color,
98100
source: linkSpec.source[i],
@@ -159,7 +161,6 @@ function linkModel(uniqueKeys, d, l) {
159161
// for event data
160162
l.trace = d.trace;
161163
l.curveNumber = d.trace.index;
162-
l.pointNumber = 'TODO';
163164

164165
return {
165166
key: key,
@@ -191,7 +192,6 @@ function nodeModel(uniqueKeys, d, n) {
191192
// for event data
192193
n.trace = d.trace;
193194
n.curveNumber = d.trace.index;
194-
n.pointNumber = 'TODO';
195195

196196
return {
197197
key: key,
@@ -424,7 +424,6 @@ function snappingForce(sankeyNode, forceKey, nodes, d) {
424424
// scene graph
425425

426426
module.exports = function(svg, styledData, layout, callbacks) {
427-
428427
var sankey = svg.selectAll('.sankey')
429428
.data(styledData
430429
.filter(function(d) {return unwrap(d).trace.visible;})

test/jasmine/tests/sankey_test.js

+18-6
Original file line numberDiff line numberDiff line change
@@ -470,37 +470,49 @@ describe('sankey tests', function() {
470470
.then(function() { return _hover('node'); })
471471
.then(function(d) {
472472
_assert(d, {
473-
curveNumber: 0
473+
curveNumber: 0,
474+
pointNumber: 4,
475+
label: 'Solid'
474476
});
475477
})
476478
.then(function() { return _hover('link'); })
477479
.then(function(d) {
478480
_assert(d, {
479-
curveNumber: 0
481+
curveNumber: 0,
482+
pointNumber: 61,
483+
value: 46.477
480484
});
481485
})
482486
.then(function() { return _click('node'); })
483487
.then(function(d) {
484488
_assert(d, {
485-
curveNumber: 0
489+
curveNumber: 0,
490+
pointNumber: 4,
491+
label: 'Solid'
486492
});
487493
})
488494
.then(function() { return _click('link'); })
489495
.then(function(d) {
490496
_assert(d, {
491-
curveNumber: 0
497+
curveNumber: 0,
498+
pointNumber: 61,
499+
value: 46.477
492500
});
493501
})
494502
.then(function() { return _unhover('node'); })
495503
.then(function(d) {
496504
_assert(d, {
497-
curveNumber: 0
505+
curveNumber: 0,
506+
pointNumber: 4,
507+
label: 'Solid'
498508
});
499509
})
500510
.then(function() { return _unhover('link'); })
501511
.then(function(d) {
502512
_assert(d, {
503-
curveNumber: 0
513+
curveNumber: 0,
514+
pointNumber: 61,
515+
value: 46.477
504516
});
505517
})
506518
.catch(fail)

0 commit comments

Comments
 (0)