Skip to content

Commit 0e35a0f

Browse files
Improve z-new_tickmode_sync.json
1 parent 12ae78b commit 0e35a0f

File tree

2 files changed

+29
-22
lines changed

2 files changed

+29
-22
lines changed

src/plots/cartesian/axes.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,17 +1228,17 @@ function syncTicks(ax) {
12281228
var ticksOut = [];
12291229
if(baseAxis._vals) {
12301230
for(var i = 0; i < baseAxis._vals.length; i++) {
1231+
// filter vals with noTick flag
1232+
if(baseAxis._vals[i].noTick) {
1233+
continue;
1234+
}
1235+
12311236
// get the position of the every tick
12321237
var pos = baseAxis.l2p(baseAxis._vals[i].x);
12331238

12341239
// get the tick for the current axis based on position
12351240
var vali = ax.p2l(pos);
1236-
var val1 = ax.p2l(pos - 0.1);
1237-
var val2 = ax.p2l(pos + 0.1);
1238-
var d = 1 + Math.round(Math.log10(Math.abs(val2 - val1)));
1239-
var e = Math.pow(10, -d);
1240-
var valR = Math.round(vali * e) / e;
1241-
var obj = axes.tickText(ax, valR);
1241+
var obj = axes.tickText(ax, vali);
12421242

12431243
// assign minor ticks
12441244
if(baseAxis._vals[i].minor) {

test/image/mocks/z-new_tickmode_sync.json

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
"name": "Apples",
55
"type": "bar",
66
"x": [
7-
"Jan",
8-
"Feb",
9-
"Mar",
10-
"Apr",
11-
"May"
7+
"2000-01",
8+
"2000-02",
9+
"2000-03",
10+
"2000-04",
11+
"2000-05"
1212
],
1313
"y": [
1414
232,
@@ -24,13 +24,17 @@
2424
"x": [
2525
"A",
2626
"B",
27-
"C"
28-
],
29-
"y": [
27+
"C",
28+
"D",
29+
"E"
30+
],
31+
"y": [
3032
0,
31-
0.5,
32-
1
33-
],
33+
0.4,
34+
0.1,
35+
0.3,
36+
0.2
37+
],
3438
"yaxis": "y2",
3539
"xaxis": "x2"
3640
}
@@ -44,15 +48,18 @@
4448
},
4549
"width": 700,
4650
"showlegend": false,
51+
"xaxis": {
52+
"ticklen": 10,
53+
"tickwidth": 3,
54+
"ticklabelmode": "period"
55+
},
4756
"xaxis2": {
4857
"anchor": "y2",
4958
"side": "top",
5059
"overlaying": "x",
5160
"tickmode": "sync",
52-
"domain": [
53-
0.52,
54-
1
55-
]
61+
"ticklen": 10,
62+
"tickwidth": 3
5663
},
5764
"yaxis": {
5865
"title": {
@@ -61,7 +68,7 @@
6168
"side": "left",
6269
"range": [
6370
0,
64-
2506
71+
2500
6572
],
6673
"ticklen": 10,
6774
"tickwidth": 3,

0 commit comments

Comments
 (0)