Skip to content

Commit 0d65012

Browse files
committed
test case update for cross-OS hover check
1 parent 7005671 commit 0d65012

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

test/jasmine/tests/parcoords_test.js

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -648,40 +648,45 @@ describe('parcoords', function() {
648648

649649
it('Should emit a \'plotly_hover\' event', function(done) {
650650

651-
var tester = (function() {
651+
function testMaker() {
652652

653653
var eventCalled = false;
654654

655655
return {
656-
set: function(d) {eventCalled = d;},
656+
set: function() {eventCalled = eventCalled || true;},
657657
get: function() {return eventCalled;}
658658
};
659-
})();
659+
}
660+
661+
var hoverTester = testMaker();
662+
var unhoverTester = testMaker();
660663

661664
gd.on('plotly_hover', function(d) {
662-
tester.set({hover: d});
665+
hoverTester.set({hover: d});
663666
});
664667

665668
gd.on('plotly_unhover', function(d) {
666-
tester.set({unhover: d});
669+
unhoverTester.set({unhover: d});
667670
});
668671

669-
expect(tester.get()).toBe(false);
672+
expect(hoverTester.get()).toBe(false);
673+
expect(unhoverTester.get()).toBe(false);
670674

671675
mouseEvent('mousemove', 324, 216);
672676
mouseEvent('mouseover', 324, 216);
677+
mouseEvent('mousemove', 315, 218);
678+
mouseEvent('mouseover', 315, 218);
673679

674680
window.setTimeout(function() {
675681

676-
expect(tester.get().hover && tester.get().hover.curveNumber).not.toBe(null);
677-
expect(tester.get().hover && tester.get().hover.curveNumber).not.toBe(undefined);
682+
expect(hoverTester.get()).toBe(true);
678683

679684
mouseEvent('mousemove', 329, 153);
680685
mouseEvent('mouseover', 329, 153);
681686

682687
window.setTimeout(function() {
683688

684-
expect(tester.get().unhover && tester.get().unhover.curveNumber).toBe(null);
689+
expect(unhoverTester.get()).toBe(true);
685690
done();
686691
}, 20);
687692

0 commit comments

Comments
 (0)