Skip to content

Commit 0bb032f

Browse files
authored
Merge pull request #2593 from plotly/scattergl-fix-n
Scattergl selection / clustering fix
2 parents ef6b259 + f7dc6b3 commit 0bb032f

File tree

7 files changed

+81
-26
lines changed

7 files changed

+81
-26
lines changed

package-lock.json

+30-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@
9595
"ndarray-fill": "^1.0.2",
9696
"ndarray-homography": "^1.0.0",
9797
"ndarray-ops": "^1.2.2",
98-
"point-cluster": "^3.1.2",
98+
"point-cluster": "^3.1.4",
9999
"polybooljs": "^1.2.0",
100100
"regl": "^1.3.1",
101-
"regl-error2d": "^2.0.3",
102-
"regl-line2d": "^3.0.8",
103-
"regl-scatter2d": "^3.0.1",
104-
"regl-splom": "^1.0.0",
101+
"regl-error2d": "^2.0.5",
102+
"regl-line2d": "^3.0.9",
103+
"regl-scatter2d": "^3.0.4",
104+
"regl-splom": "^1.0.3",
105105
"right-now": "^1.0.0",
106106
"robust-orientation": "^1.1.3",
107107
"sane-topojson": "^2.0.0",

src/traces/scattergl/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ function plot(gd, subplot, cdata) {
546546
}
547547
}
548548

549-
// uploat viewport/range data to GPU
549+
// upload viewport/range data to GPU
550550
if(scene.fill2d) {
551551
scene.fill2d.update(vpRange);
552552
}
Loading
Loading

test/image/mocks/gl2d_scatter-continuous-clustering.json

+30
Large diffs are not rendered by default.

test/jasmine/tests/splom_test.js

+15
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,21 @@ describe('@gl Test splom interactions:', function() {
549549
.catch(failTest)
550550
.then(done);
551551
});
552+
553+
it('should work with typed arrays', function(done) {
554+
Plotly.plot(gd, [{
555+
type: 'splom',
556+
dimensions: [{
557+
label: 'A',
558+
values: new Int32Array([1, 2, 3])
559+
}, {
560+
label: 'B',
561+
values: new Int32Array([2, 5, 6])
562+
}]
563+
}])
564+
.catch(failTest)
565+
.then(done);
566+
});
552567
});
553568

554569
describe('@gl Test splom hover:', function() {

0 commit comments

Comments
 (0)