Skip to content

Commit 072f028

Browse files
committed
fixup trace deletion for carpet traces
- which is a weird case. It relies on trace.uid (like heatmaps/contour), but has <g.trace> group (like scatter/bar/...) which previously got deleted in that big selectAll('g.trace').remove() in Cartesian.plot. Now make _module.plot take care of trace deletion!
1 parent b4ea2ce commit 072f028

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/traces/carpet/plot.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ var Lib = require('../../lib');
1919
var alignmentConstants = require('../../constants/alignment');
2020

2121
module.exports = function plot(gd, plotinfo, cdcarpet) {
22+
if(!cdcarpet.length) {
23+
plotinfo.plot.select('.carpetlayer')
24+
.selectAll('g.trace')
25+
.remove();
26+
}
27+
2228
for(var i = 0; i < cdcarpet.length; i++) {
2329
plotOne(gd, plotinfo, cdcarpet[i]);
2430
}
@@ -33,7 +39,7 @@ function plotOne(gd, plotinfo, cd) {
3339
bax = trace.baxis,
3440
fullLayout = gd._fullLayout;
3541

36-
var gridLayer = plotinfo.plot.selectAll('.carpetlayer');
42+
var gridLayer = plotinfo.plot.select('.carpetlayer');
3743
var clipLayer = fullLayout._clips;
3844

3945
var axisLayer = Lib.ensureSingle(gridLayer, 'g', 'carpet' + trace.uid).classed('trace', true);

0 commit comments

Comments
 (0)