Skip to content

Commit 0221510

Browse files
committed
🔪 obsolete _xp, _yp from carpet
1 parent 5546ec7 commit 0221510

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/traces/carpet/calc.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ module.exports = function calc(gd, trace) {
6565
// create conversion functions that depend on the data
6666
trace.setScale();
6767

68-
// Convert cartesian-space x/y coordinates to screen space pixel coordinates:
69-
t.xp = trace._xp = map2dArray(trace._xp, x, xa.c2p);
70-
t.yp = trace._yp = map2dArray(trace._yp, y, ya.c2p);
71-
7268
// This is a rather expensive scan. Nothing guarantees monotonicity,
7369
// so we need to scan through all data to get proper ranges:
7470
var xrange = arrayMinmax(x);
@@ -92,8 +88,8 @@ module.exports = function calc(gd, trace) {
9288

9389
// Enumerate the gridlines, both major and minor, and store them on the trace
9490
// object:
95-
calcGridlines(trace, t, 'a', 'b');
96-
calcGridlines(trace, t, 'b', 'a');
91+
calcGridlines(trace, 'a', 'b');
92+
calcGridlines(trace, 'b', 'a');
9793

9894
// Calculate the text labels for each major gridline and store them on the
9995
// trace object:

src/traces/carpet/calc_gridlines.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
var Axes = require('../../plots/cartesian/axes');
1212
var extendFlat = require('../../lib/extend').extendFlat;
1313

14-
module.exports = function calcGridlines(trace, cd, axisLetter, crossAxisLetter) {
14+
module.exports = function calcGridlines(trace, axisLetter, crossAxisLetter) {
1515
var i, j, j0;
1616
var eps, bounds, n1, n2, n, value, v;
1717
var j1, v0, v1, d;

0 commit comments

Comments
 (0)