add legacy deprecation warnings

Author: etpinard

src/plot_api/plot_api.js

@@ -144,8 +144,11 @@ Plotly.plot = function(gd, data, layout, config) {
 
     var fullLayout = gd._fullLayout;
 
-    // Polar plots
-    if(data && data[0] && data[0].r) return plotPolar(gd, data, layout);
+    // Legacy polar plots
+    if(!fullLayout._has('polar') && data && data[0] && data[0].r) {
+        Lib.warn('Legacy polar charts are deprecated!');
+        return plotPolar(gd, data, layout);
+    }
 
     // so we don't try to re-call Plotly.plot from inside
     // legend and colorbar, if margins changed

src/traces/scatter/attributes.js

@@ -477,15 +477,17 @@ module.exports = {
         valType: 'data_array',
         editType: 'calc',
         description: [
-            'For polar chart only.',
+            'For legacy polar chart only.',
+            'Please switch to *scatterpolar* trace type.',
             'Sets the radial coordinates.'
         ].join('')
     },
     t: {
         valType: 'data_array',
         editType: 'calc',
         description: [
-            'For polar chart only.',
+            'For legacy polar chart only.',
+            'Please switch to *scatterpolar* trace type.',
             'Sets the angular coordinates.'
         ].join('')
     },

test/jasmine/tests/plot_interact_test.js

@@ -464,25 +464,6 @@ describe('Test plot structure', function() {
             });
         });
     });
-
-    describe('polar plots', function() {
-        var mock = require('@mocks/polar_scatter.json');
-
-        beforeEach(function(done) {
-            Plotly.plot(createGraphDiv(), mock.data, mock.layout).then(done);
-        });
-
-        it('has as many *mark dot* nodes as there are points', function() {
-            var nodes = d3.selectAll('path.mark.dot');
-
-            var Npts = 0;
-            mock.data.forEach(function(trace) {
-                Npts += trace.r.length;
-            });
-
-            expect(nodes.size()).toEqual(Npts);
-        });
-    });
 });
 
 describe('plot svg clip paths', function() {

test/jasmine/tests/polar_test.js

@@ -1,6 +1,56 @@
+var Plotly = require('@lib');
 var Lib = require('@src/lib');
 var Polar = require('@src/plots/polar');
 
+var createGraphDiv = require('../assets/create_graph_div');
+var destroyGraphDiv = require('../assets/destroy_graph_div');
+var fail = require('../assets/fail_test');
+
+describe('Test legacy polar plots logs:', function() {
+    var gd;
+
+    beforeEach(function() {
+        spyOn(Lib, 'warn');
+        gd = createGraphDiv();
+    });
+
+    afterEach(destroyGraphDiv);
+
+    var specs = [{
+        name: 'legacy polar scatter traces',
+        data: [{
+            r: [1, 2, 3],
+            t: [1, 2, 3]
+        }]
+    }, {
+        name: 'legacy polar bar traces',
+        data: [{
+            type: 'bar',
+            r: [1, 2, 3],
+            t: [1, 2, 3]
+        }]
+    }, {
+        name: 'legacy area traces',
+        data: [{
+            type: 'area',
+            r: [1, 2, 3],
+            t: [1, 2, 3]
+        }]
+    }];
+
+    specs.forEach(function(s) {
+        it('should log deprecation warning on ' + s.name, function(done) {
+            Plotly.plot(gd, s.data)
+            .then(function() {
+                expect(Lib.warn).toHaveBeenCalledTimes(1);
+                expect(Lib.warn).toHaveBeenCalledWith('Legacy polar charts are deprecated!');
+            })
+            .catch(fail)
+            .then(done);
+        });
+    });
+});
+
 describe('Test polar plots defaults:', function() {
     var layoutOut;