Support mode="text+markers" #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mkcor opened this issue Mar 16, 2015 · 2 comments

Contributor

mkcor commented Mar 16, 2015

See bullet points at the end of http://stackoverflow.com/questions/29068867/plotly-not-getting-geom-text-in-r-ggplot/29086989#29086989

/cc @chriddyp @tdhock @cpsievert

Contributor

tdhock commented Mar 16, 2015

I recently added some code to support this (along with the error-bars merging code)

https://github.com/ropensci/plotly/blob/master/R/ggplotly.R#L712-L757

There are some tests for merging lines, points, and error bars

https://github.com/ropensci/plotly/blob/master/tests/testthat/test-mean-error-bars.R

but I guess we need to add some tests for the case of just geom_point and geom_line (no error bars).

Collaborator

cpsievert commented Mar 17, 2016

FWIW, this is the new approach to merging -- https://github.com/ropensci/plotly/blob/78e4612597a4ba3e3b95ad2747867363613d1448/R/ggplotly.R#L610-L628

I rarely ever see anyone wanting to plot text and points at the same x/y so I don't think this is really worth the effort

cpsievert closed this as completed

jblamyatifremer mentioned this issue

intentional duplicated catergorical items disappear when plotting #1678

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment