-
Notifications
You must be signed in to change notification settings - Fork 633
plotlyjs upgrade in v4.7 breaks some plots on shiny-server rendered flex dashboard #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have a feeling the problem was introduced in 183006c. Can you revert just that commit and see if it helps? |
Ahh, yea, ok, I think it was the removal of the yaml file (I don't think the version of plotly.js has anything to do with it). I'll add it back for now, but I'll have to ask around to see if that's the best way to proceed officially. |
Update 1: forgot to change plotlyjs version number in updating these files, will try again to see if it works.Update 2: after correcting version number in yaml, error is still present.Reverting only changes in commit 183006c still results in a similar error. Error w/partial revertResults when running properly*note inclusion of plotlyjs in sources, not included when error was thrown. |
ok, interesting, do you mind changing just the plotly.js version to 1.27.0 (and not adding the yaml file as you have done in the plotlyjs_revert branch)? |
Empty yaml file, but using plotly.js v1.27.0 (see no_yaml_1.27.0) yields similar results. |
ok, does |
Success!
#1035 results |
Came to report the same problem, albeit in a "normal" Shiny fluidPage layout (not flex dashboard). Thanks for your quick response, Carson. |
EDIT: apologies, it did actually get the plot to appear again, thank you. Thanks again. |
@msummersgill could you please re-install via |
The shiny application in question is written and maintained by one of my coworkers, so I need to sit down with them and review all the server logs/find the underlying issue on Monday. After that, I'll let you know if the current error message is related to plotly or not. (Moral of the story: for production shiny applications, use packrat and set up a single purpose user account to run each one) |
I think this is fixed now. Feel free to open another issue if you are running into other problems. |
Note: this is unfortunately far from being a reproducible example or a clearly defined issue, but I'm posting what I've got on the off chance it can at least be a starting point towards a solution.
I've got a flexdashboard report using shiny runtime hosted on a shiny-server instance that has several plotly graphs, and after updating to the current CRAN version of plotly, v4.7, some of the plots no longer displayed, with no R error messages or warnings. The (redacted of proprietary information) image below shows what the output looks like when the report is working properly, but after updating to v4.7, the second plot from the left (scatter plot) just appears as an empty panel.
Checking in chrome developer tools there is an error message that I assume is related to the problem, looks like perhaps objects of class
Plotly
are undefined? I have next to no idea what I'm doing when it comes to javascript/html/web applications, but if I had to take a wild guess, it could either be due to an incompatibility between plotly-latest.min.js and shiny.min.js or possibly just the elimination of dependency references in inst/htmlwidgets/plotly.yaml?Ordinarily I would update shiny-server, shiny, and all the other packages in use, but I'm a little short on time this week to go through the server reboot process and risk a more extensive troubleshooting session if other packages introduced unrelated breaking updates on other applications/reports.
Let me know if there's any other information it would be helpful for me to post from the developer tools or the r session or system info.
I'm having a hard time getting this pared down to a reproducible example without extraneous information. The original dashboard pulls in a handful of pre-processed data sources and generates multiple tabs with multiple panels and plots that use click events and some other bells and whistles. After getting it cut down to a single scatter plot with the mtcars data set everything works fine...
Functioning workaround:
I forked v4.7 and reverted back the plotlyjs related changes, (msummersgill/plotlyjs_revert) and with that everything is working again.
Comparison between ropensci/master and msummersgill/plotlyjs_revert
Some other anecdotal information:
The text was updated successfully, but these errors were encountered: