Skip to content

Commit af5f6e8

Browse files
committed
Merge pull request #147 from ropensci/marianne-hipsteR-notation
Update notation and naming for modern use
2 parents 542264e + 2bb78da commit af5f6e8

File tree

5 files changed

+15
-22
lines changed

5 files changed

+15
-22
lines changed

DESCRIPTION

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: plotly
22
Type: Package
33
Title: Interactive, publication-quality graphs online.
4-
Version: 0.5.12
4+
Version: 0.5.13
55
Authors@R: c(person("Chris", "Parmer", role = c("aut", "cre"),
66
email = "[email protected]"),
77
person("Scott", "Chamberlain", role = "aut",
@@ -34,14 +34,3 @@ Imports:
3434
Suggests:
3535
maps,
3636
testthat
37-
Collate:
38-
'one_to_one_corr.R'
39-
'build_function.R'
40-
'colour_conversion.R'
41-
'ggplotly.R'
42-
'marker_conversion.R'
43-
'plotly-package.r'
44-
'plotly.R'
45-
'signup.R'
46-
'tools.R'
47-
'trace_generation.R'

NEWS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
0.5.13 -- 27 November 2014.
2+
3+
Rename translation file and server endpoint parameter to be hip.
4+
15
0.5.12 -- 12 November 2014.
26

37
Improve legend title position.
File renamed without changes.

R/plotly.R

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#' @import RJSONIO
1919
#' @param username plotly username
2020
#' @param key plotly API key
21-
#' @param base.url plotly server
21+
#' @param base_url plotly server
2222
#'
2323
#' @return An object of class PlotlyClass, except for the final object after
2424
#' adding layers becomes a list class.
@@ -57,7 +57,7 @@
5757
#' }
5858

5959

60-
plotly <- function(username=NULL, key=NULL, base.url=NULL) {
60+
plotly <- function(username=NULL, key=NULL, base_url=NULL) {
6161

6262
if (is.null(username)) {
6363
username <- get_credentials_file(c("username", "api_key"))$username
@@ -73,11 +73,11 @@ To get started, save your plotly username and API key by calling:\n
7373
For more help, see https://plot.ly/R or contact <[email protected]>.")
7474
}
7575
# Plotly server
76-
if (is.null(base.url)) {
77-
base.url <- get_config_file("plotly_domain")$plotly_domain
76+
if (is.null(base_url)) {
77+
base_url <- get_config_file("plotly_domain")$plotly_domain
7878
}
79-
if (is.null(base.url) || base.url == "") {
80-
base.url <- "https://plot.ly"
79+
if (is.null(base_url) || base_url == "") {
80+
base_url <- "https://plot.ly"
8181
}
8282

8383
# public attributes/methods that the user has access to
@@ -90,7 +90,7 @@ For more help, see https://plot.ly/R or contact <[email protected]>.")
9090
kwargs$filename <- pub$filename
9191
if (is.null(kwargs$fileopt))
9292
kwargs$fileopt <- NULL
93-
url <- paste(base.url, "/clientresp", sep="")
93+
url <- paste(base_url, "/clientresp", sep="")
9494

9595
respst <- postForm(url, platform="R", version=pub$version,
9696
args=toJSON(args, digits=50, collapse=""), un=pub$username,
@@ -167,7 +167,7 @@ For more help, see https://plot.ly/R or contact <[email protected]>.")
167167
"plotly-platform"="R")
168168
response_handler <- basicTextGatherer()
169169
header_handler <- basicTextGatherer()
170-
curlPerform(url=paste(base.url, "apigetfile", file_owner, file_id,
170+
curlPerform(url=paste(base_url, "apigetfile", file_owner, file_id,
171171
sep="/"),
172172
httpheader=headers,
173173
writefunction=response_handler$update,

man/plotly.Rd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
\alias{plotly}
44
\title{Main interface to plotly}
55
\usage{
6-
plotly(username = NULL, key = NULL, base.url = NULL)
6+
plotly(username = NULL, key = NULL, base_url = NULL)
77
}
88
\arguments{
99
\item{username}{plotly username}
1010

1111
\item{key}{plotly API key}
1212

13-
\item{base.url}{plotly server}
13+
\item{base_url}{plotly server}
1414
}
1515
\value{
1616
An object of class PlotlyClass, except for the final object after

0 commit comments

Comments
 (0)