Use rbind.data.frame to avoid method dispatch

cpsievert · cpsievert · commit a662092aefc9 · 2016-09-05T15:11:16.000-05:00
diff --git a/R/group2NA.R b/R/group2NA.R
@@ -54,10 +54,11 @@ group2NA <- function(data, groupNames = "group", nested = NULL, ordered = NULL,
   for (i in c(nested, groupNames)) {
     data <- dplyr::group_by_(data, i, add = TRUE)
   }
+  # TODO: this is slow, can it be done with dplyr::slice()?
   d <- if (retrace.first) {
-    dplyr::do(data, rbind(., .[1,], NA))
+    dplyr::do(data, rbind.data.frame(., .[1,], NA))
   } else {
-    dplyr::do(data, rbind(., NA))
+    dplyr::do(data, rbind.data.frame(., NA))
   }
   # TODO: how to drop the NAs separating the nested values? Does it even matter?
   # d <- dplyr::ungroup(d)

Original file line number	Diff line number	Diff line change
`@@ -54,10 +54,11 @@ group2NA <- function(data, groupNames = "group", nested = NULL, ordered = NULL,`
`54`	`54`	`for (i in c(nested, groupNames)) {`
`55`	`55`	`data <- dplyr::group_by_(data, i, add = TRUE)`
`56`	`56`	`}`
	`57`	`+ # TODO: this is slow, can it be done with dplyr::slice()?`
`57`	`58`	`d <- if (retrace.first) {`
`58`		`- dplyr::do(data, rbind(., .[1,], NA))`
	`59`	`+ dplyr::do(data, rbind.data.frame(., .[1,], NA))`
`59`	`60`	`} else {`
`60`		`- dplyr::do(data, rbind(., NA))`
	`61`	`+ dplyr::do(data, rbind.data.frame(., NA))`
`61`	`62`	`}`
`62`	`63`	`# TODO: how to drop the NAs separating the nested values? Does it even matter?`
`63`	`64`	`# d <- dplyr::ungroup(d)`