margin of 0 wasn't a good idea

Author: cpsievert

R/subplots.R

@@ -22,7 +22,7 @@
 
 
 ## TODO: throw warning if geo and non-geo coordinates are used!!!
-subplot <- function(..., nrows = 1, which_layout = "merge", margin = 0) {
+subplot <- function(..., nrows = 1, which_layout = "merge", margin = 0.1 /nrows) {
   # note that dots is a _list of plotlys_
   dots <- lapply(list(...), plotly_build)
   # put existing plot anchors and domain information into a tidy format

tests/testthat/test-plotly-subplot.R

@@ -2,7 +2,7 @@ context("subplot")
 
 expect_traces <- function(p, n.traces, name){
   stopifnot(is.numeric(n.traces))
-  L <- save_outputs(p, paste0("plotly-subplot", name))
+  L <- save_outputs(p, paste0("plotly-subplot-", name))
   expect_equal(length(L$data), n.traces)
   L
 }
@@ -14,7 +14,7 @@ test_that("simple subplot works", {
   expect_identical(s$data[[2]]$xaxis, s$layout[["yaxis2"]][["anchor"]])
   expect_identical(s$data[[2]]$yaxis, s$layout[["xaxis2"]][["anchor"]])
   doms <- lapply(s$layout, "[[", "domain")
-  expect_true(doms$xaxis[2] < doms$xaxis2[1])
+  expect_true(doms$xaxis[2] <= doms$xaxis2[1])
 })
 
 test_that("nrows argument works", {
@@ -24,7 +24,7 @@ test_that("nrows argument works", {
   expect_identical(s$data[[2]]$xaxis, s$layout[["yaxis2"]][["anchor"]])
   expect_identical(s$data[[2]]$yaxis, s$layout[["xaxis2"]][["anchor"]])
   doms <- lapply(s$layout, "[[", "domain")
-  expect_true(doms$yaxis[1] > doms$yaxis2[2])
+  expect_true(doms$yaxis[1] >= doms$yaxis2[2])
 })