update "group" tests in "markers" and "lines" modes

Author: alyst

tests/testthat/test-plotly.R

@@ -17,12 +17,26 @@ test_that("plot_ly() handles a simple scatterplot", {
   expect_identical(l$layout$yaxis$title, "Petal.Length")
 })
 
-test_that("Using group argument creates multiple traces", {
-  skip("FIXME disabled since group doesn't create new traces now")
-  p <- plot_ly(data = iris, x = Sepal.Length, y = Petal.Length, group = Species)
-  l <- expect_traces(p, 3, "scatterplot-group")
+test_that("Using group argument doesn't transform the data in markers mode", {
+  p <- plot_ly(data = iris, x = Sepal.Length, y = Petal.Length, group = Species, mode = "markers")
+  l <- expect_traces(p, 1, "scatterplot-group-markers")
   expect_identical(l$layout$xaxis$title, "Sepal.Length")
   expect_identical(l$layout$yaxis$title, "Petal.Length")
+  expect_identical(l$data[[1]]$group, iris$Species)
+})
+
+test_that("Using group argument for scatter plot in lines mode introduces breaks (NA values separating different groups)", {
+  p <- plot_ly(data = iris, x = Sepal.Length, y = Petal.Length, group = Species, mode = "lines")
+  l <- expect_traces(p, 1, "scatterplot-group")
+  expect_identical(l$layout$xaxis$title, "Sepal.Length")
+  expect_identical(l$layout$yaxis$title, "Petal.Length")
+  n_groups <- length(unique(iris$Species))
+  n_pts <- length(l$data[[1]]$x)
+  expect_identical(n_pts, nrow(iris)+n_groups-1L)
+  expect_identical(sum(is.na(l$data[[1]]$x)), n_groups-1L)
+  expect_true(all(is.na(l$data[[1]]$group[-1]) |
+                  is.na(l$data[[1]]$group[-n_pts]) |
+                  (l$data[[1]]$group[-1] == l$data[[1]]$group[-n_pts])))
 })
 
 test_that("Mapping a variable to symbol works", {