Skip to content

Commit 81483dc

Browse files
pedrodzpedrodz
committed
Merge pull request #125 from ropensci/pd-ggplot-no-zeroline
ggplot: no zeroline
2 parents d49ce33 + 0ec6e6a commit 81483dc

File tree

102 files changed

+506
-3
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+506
-3
lines changed

‎DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: plotly
22
Type: Package
33
Title: Interactive, publication-quality graphs online.
4-
Version: 0.5.0
4+
Version: 0.5.1
55
Authors@R: c(person("Chris", "Parmer", role = c("aut", "cre"),
66
email = "[email protected]"),
77
person("Scott", "Chamberlain", role = "aut",

‎R/ggplotly.R

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,9 @@ gg2list <- function(p){
321321
}else{
322322
stop("unrecognized data type for ", xy, " axis")
323323
}
324-
## Lines drawn around the plot border:
324+
325+
ax.list$zeroline <- FALSE # ggplot2 plots do not show zero lines
326+
# Lines drawn around the plot border.
325327
ax.list$showline <- !is.blank("panel.border", TRUE)
326328
ax.list$linecolor <- toRGB(theme.pars$panel.border$colour)
327329
ax.list$linewidth <- theme.pars$panel.border$size

‎R/plotly.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ For more help, see https://plot.ly/R or contact <[email protected]>.")
8282

8383
# public attributes/methods that the user has access to
8484
pub <- list(username=username, key=key, filename="from api", fileopt=NULL,
85-
version="0.5.0")
85+
version="0.5.1")
8686
priv <- list()
8787

8888
pub$makecall <- function(args, kwargs, origin) {

‎tests/testthat/test-ggplot-abline-plotly.png

-27 Bytes

‎tests/testthat/test-ggplot-abline.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
"title": "x1",
6767
"type": "linear",
6868
"showgrid": true,
69+
"zeroline": false,
6970
"showline": false,
7071
"ticks": "outside",
7172
"showticklabels": true,
@@ -76,6 +77,7 @@
7677
"title": "x2",
7778
"type": "linear",
7879
"showgrid": true,
80+
"zeroline": false,
7981
"showline": false,
8082
"ticks": "outside",
8183
"showticklabels": true,

‎tests/testthat/test-ggplot-area-plotly.png

-68 Bytes

‎tests/testthat/test-ggplot-area.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@
221221
"title": "year",
222222
"type": "linear",
223223
"showgrid": true,
224+
"zeroline": false,
224225
"showline": false,
225226
"ticks": "outside",
226227
"showticklabels": true,
@@ -231,6 +232,7 @@
231232
"title": "level",
232233
"type": "linear",
233234
"showgrid": true,
235+
"zeroline": false,
234236
"showline": false,
235237
"ticks": "outside",
236238
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-category-names-plotly.png

-32 Bytes

‎tests/testthat/test-ggplot-bar-category-names.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
"title": "cut",
121121
"type": "category",
122122
"showgrid": true,
123+
"zeroline": false,
123124
"showline": false,
124125
"ticks": "outside",
125126
"showticklabels": true,
@@ -130,6 +131,7 @@
130131
"title": "price",
131132
"type": "linear",
132133
"showgrid": true,
134+
"zeroline": false,
133135
"showline": false,
134136
"ticks": "outside",
135137
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-dates-plotly.png

-83 Bytes

‎tests/testthat/test-ggplot-bar-dates.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"title": "month",
4545
"type": "date",
4646
"showgrid": true,
47+
"zeroline": false,
4748
"showline": false,
4849
"ticks": "outside",
4950
"showticklabels": true,
@@ -54,6 +55,7 @@
5455
"title": "papers",
5556
"type": "linear",
5657
"showgrid": true,
58+
"zeroline": false,
5759
"showline": false,
5860
"ticks": "outside",
5961
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-dodge-plotly.png

-74 Bytes

‎tests/testthat/test-ggplot-bar-dodge.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"title": "country",
4545
"type": "category",
4646
"showgrid": true,
47+
"zeroline": false,
4748
"showline": false,
4849
"ticks": "outside",
4950
"showticklabels": true,
@@ -54,6 +55,7 @@
5455
"title": "papers",
5556
"type": "linear",
5657
"showgrid": true,
58+
"zeroline": false,
5759
"showline": false,
5860
"ticks": "outside",
5961
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-factor-category.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@
129129
"title": "cut",
130130
"type": "category",
131131
"showgrid": true,
132+
"zeroline": false,
132133
"showline": false,
133134
"ticks": "outside",
134135
"showticklabels": true,
@@ -139,6 +140,7 @@
139140
"title": "price",
140141
"type": "linear",
141142
"showgrid": true,
143+
"zeroline": false,
142144
"showline": false,
143145
"ticks": "outside",
144146
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-identity-plotly.png

-55 Bytes

‎tests/testthat/test-ggplot-bar-identity.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"title": "country",
4545
"type": "category",
4646
"showgrid": true,
47+
"zeroline": false,
4748
"showline": false,
4849
"ticks": "outside",
4950
"showticklabels": true,
@@ -54,6 +55,7 @@
5455
"title": "papers",
5556
"type": "linear",
5657
"showgrid": true,
58+
"zeroline": false,
5759
"showline": false,
5860
"ticks": "outside",
5961
"showticklabels": true,

‎tests/testthat/test-ggplot-bar-stack-plotly.png

-53 Bytes

‎tests/testthat/test-ggplot-bar-stack.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"title": "country",
4545
"type": "category",
4646
"showgrid": true,
47+
"zeroline": false,
4748
"showline": false,
4849
"ticks": "outside",
4950
"showticklabels": true,
@@ -54,6 +55,7 @@
5455
"title": "papers",
5556
"type": "linear",
5657
"showgrid": true,
58+
"zeroline": false,
5759
"showline": false,
5860
"ticks": "outside",
5961
"showticklabels": true,

‎tests/testthat/test-ggplot-boxplot-datetime.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"title": "x",
2626
"type": "linear",
2727
"showgrid": true,
28+
"zeroline": false,
2829
"showline": false,
2930
"ticks": "outside",
3031
"showticklabels": true,
@@ -35,6 +36,7 @@
3536
"title": "y",
3637
"type": "date",
3738
"showgrid": true,
39+
"zeroline": false,
3840
"showline": false,
3941
"ticks": "outside",
4042
"showticklabels": true,

‎tests/testthat/test-ggplot-boxplot.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
"title": "factor(cyl)",
6767
"type": "category",
6868
"showgrid": true,
69+
"zeroline": false,
6970
"showline": false,
7071
"ticks": "outside",
7172
"showticklabels": true,
@@ -76,6 +77,7 @@
7677
"title": "mpg",
7778
"type": "linear",
7879
"showgrid": true,
80+
"zeroline": false,
7981
"showline": false,
8082
"ticks": "outside",
8183
"showticklabels": true,

‎tests/testthat/test-ggplot-contour.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5608,6 +5608,7 @@
56085608
"title": "x",
56095609
"type": "linear",
56105610
"showgrid": true,
5611+
"zeroline": false,
56115612
"showline": false,
56125613
"ticks": "outside",
56135614
"showticklabels": true,
@@ -5618,6 +5619,7 @@
56185619
"title": "y",
56195620
"type": "linear",
56205621
"showgrid": true,
5622+
"zeroline": false,
56215623
"showline": false,
56225624
"ticks": "outside",
56235625
"showticklabels": true,

‎tests/testthat/test-ggplot-date-class-Date.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"title": "x",
3434
"type": "date",
3535
"showgrid": true,
36+
"zeroline": false,
3637
"showline": false,
3738
"ticks": "outside",
3839
"showticklabels": true,
@@ -43,6 +44,7 @@
4344
"title": "y",
4445
"type": "linear",
4546
"showgrid": true,
47+
"zeroline": false,
4648
"showline": false,
4749
"ticks": "outside",
4850
"showticklabels": true,

‎tests/testthat/test-ggplot-date-irregular-time-series.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@
127127
"title": "date",
128128
"type": "date",
129129
"showgrid": true,
130+
"zeroline": false,
130131
"showline": false,
131132
"ticks": "outside",
132133
"showticklabels": true,
@@ -137,6 +138,7 @@
137138
"title": "price",
138139
"type": "linear",
139140
"showgrid": true,
141+
"zeroline": false,
140142
"showline": false,
141143
"ticks": "outside",
142144
"showticklabels": true,

‎tests/testthat/test-ggplot-date-strings-plotly.png

-9 Bytes

‎tests/testthat/test-ggplot-date-strings.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
"title": "time.obj",
5353
"type": "date",
5454
"showgrid": true,
55+
"zeroline": false,
5556
"showline": false,
5657
"ticks": "outside",
5758
"showticklabels": true,
@@ -62,6 +63,7 @@
6263
"title": "dollars",
6364
"type": "linear",
6465
"showgrid": true,
66+
"zeroline": false,
6567
"showline": false,
6668
"ticks": "outside",
6769
"showticklabels": true,

‎tests/testthat/test-ggplot-density-plotly.png

-43 Bytes

‎tests/testthat/test-ggplot-density.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58808,6 +58808,7 @@
5880858808
"title": "rating",
5880958809
"type": "linear",
5881058810
"showgrid": true,
58811+
"zeroline": false,
5881158812
"showline": false,
5881258813
"ticks": "outside",
5881358814
"showticklabels": true,
@@ -58818,6 +58819,7 @@
5881858819
"title": "density",
5881958820
"type": "linear",
5882058821
"showgrid": true,
58822+
"zeroline": false,
5882158823
"showline": false,
5882258824
"ticks": "outside",
5882358825
"showticklabels": true,

‎tests/testthat/test-ggplot-density2d-plotly.png

-46 Bytes

‎tests/testthat/test-ggplot-density2d.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@
627627
"title": "duration",
628628
"type": "linear",
629629
"showgrid": true,
630+
"zeroline": false,
630631
"showline": false,
631632
"ticks": "outside",
632633
"showticklabels": true,
@@ -637,6 +638,7 @@
637638
"title": "waiting",
638639
"type": "linear",
639640
"showgrid": true,
641+
"zeroline": false,
640642
"showline": false,
641643
"ticks": "outside",
642644
"showticklabels": true,

‎tests/testthat/test-ggplot-errorbar-horizontal.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"title": "resp",
7979
"type": "linear",
8080
"showgrid": true,
81+
"zeroline": false,
8182
"showline": false,
8283
"ticks": "outside",
8384
"showticklabels": true,
@@ -88,6 +89,7 @@
8889
"title": "trt",
8990
"type": "category",
9091
"showgrid": true,
92+
"zeroline": false,
9193
"showline": false,
9294
"ticks": "outside",
9395
"showticklabels": true,

‎tests/testthat/test-ggplot-errorbar.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
"title": "cyl",
4646
"type": "linear",
4747
"showgrid": true,
48+
"zeroline": false,
4849
"showline": false,
4950
"ticks": "outside",
5051
"showticklabels": true,
@@ -55,6 +56,7 @@
5556
"title": "mpg[, \"Mean\"]",
5657
"type": "linear",
5758
"showgrid": true,
59+
"zeroline": false,
5860
"showline": false,
5961
"ticks": "outside",
6062
"showticklabels": true,

‎tests/testthat/test-ggplot-heatmap.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
"title": "Var1",
5252
"type": "category",
5353
"showgrid": true,
54+
"zeroline": false,
5455
"showline": false,
5556
"ticks": "outside",
5657
"showticklabels": true,
@@ -61,6 +62,7 @@
6162
"title": "Var2",
6263
"type": "category",
6364
"showgrid": true,
65+
"zeroline": false,
6466
"showline": false,
6567
"ticks": "outside",
6668
"showticklabels": true,

‎tests/testthat/test-ggplot-histogram-barmodestack-plotly.png

-14 Bytes

‎tests/testthat/test-ggplot-histogram-barmodestack.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"title": "country",
2626
"type": "category",
2727
"showgrid": true,
28+
"zeroline": false,
2829
"showline": false,
2930
"ticks": "outside",
3031
"showticklabels": true,
@@ -35,6 +36,7 @@
3536
"title": "count",
3637
"type": "linear",
3738
"showgrid": true,
39+
"zeroline": false,
3840
"showline": false,
3941
"ticks": "outside",
4042
"showticklabels": true,

‎tests/testthat/test-ggplot-histogram-binwidth-plotly.png

-16 Bytes

‎tests/testthat/test-ggplot-histogram-binwidth.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
"title": "x",
7575
"type": "linear",
7676
"showgrid": true,
77+
"zeroline": false,
7778
"showline": false,
7879
"ticks": "outside",
7980
"showticklabels": true,
@@ -84,6 +85,7 @@
8485
"title": "count",
8586
"type": "linear",
8687
"showgrid": true,
88+
"zeroline": false,
8789
"showline": false,
8890
"ticks": "outside",
8991
"showticklabels": true,

‎tests/testthat/test-ggplot-histogram-dates-plotly.png

-13 Bytes

‎tests/testthat/test-ggplot-histogram-dates.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"title": "month",
2626
"type": "date",
2727
"showgrid": true,
28+
"zeroline": false,
2829
"showline": false,
2930
"ticks": "outside",
3031
"showticklabels": true,
@@ -35,6 +36,7 @@
3536
"title": "count",
3637
"type": "linear",
3738
"showgrid": true,
39+
"zeroline": false,
3840
"showline": false,
3941
"ticks": "outside",
4042
"showticklabels": true,

‎tests/testthat/test-ggplot-hline-plotly.png

-197 Bytes

‎tests/testthat/test-ggplot-hline.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
"title": "x1",
6767
"type": "linear",
6868
"showgrid": true,
69+
"zeroline": false,
6970
"showline": false,
7071
"ticks": "outside",
7172
"showticklabels": true,
@@ -76,6 +77,7 @@
7677
"title": "x2",
7778
"type": "linear",
7879
"showgrid": true,
80+
"zeroline": false,
7981
"showline": false,
8082
"ticks": "outside",
8183
"showticklabels": true,

‎tests/testthat/test-ggplot-labels-angles-plotly.png

-27 Bytes

0 commit comments

Comments
 (0)