first attempt at #768

Author: cpsievert

NAMESPACE

@@ -3,6 +3,7 @@
 S3method(arrange_,plotly)
 S3method(distinct_,plotly)
 S3method(do_,plotly)
+S3method(embed_notebook,plotly)
 S3method(filter_,plotly)
 S3method(fortify,SharedData)
 S3method(geom2trace,GeomBar)

R/print.R

@@ -31,31 +31,32 @@ knit_print.plotly_figure <- function(x, options, ...) {
 #' \code{plot_ly} is used. If that is also \code{NULL}, '100\%' is the default.
 #' @param height attribute of the iframe. If \code{NULL}, the height in
 #' \code{plot_ly} is used. If that is also \code{NULL}, '400px' is the default.
-#' @param file a filename for saving the standalone HTML
-#' (only used if x is a non-figure object)
 #' @export
-embed_notebook <- function(x, width = NULL, height = NULL,
-                           file = paste0("plotlyJupyterHTML/", digest::digest(Sys.time()), ".html")) {
+embed_notebook <- function(x, width = NULL, height = NULL) {
   if (system.file(package = "IRdisplay") == "") {
     warning("You need the IRdisplay package to use this function: \n",
             "devtools::install_github(c('IRkernel/repr', 'IRKernel/IRdisplay'))")
     return(x)
   }
-  l <- plotly_build(x)
-  src <- if (is.null(l$url)) {
-    dir <- dirname(file)
-    if (!dir.exists(dir)) dir.create(dir, recursive = TRUE)
-    owd <- setwd(dir)
-    on.exit(setwd(owd), add = TRUE)
-    htmlwidgets::saveWidget(l, file = basename(file))
-    file
-  } else {
-    l$url
+  UseMethod("embed_notebook")
+}
+
+#' @export
+embed_notebook.plotly <- function(x, width = NULL, height = NULL) {
+  p <- plotly_build(x)
+  p$width <- width %||% p$width
+  p$height <- height %||% p$height
+  html <- getFromNamespace("toHTML", asNamespace("htmlwidgets"))(p)
+  # if we've already printed a plotly object, remove it's dependencies
+  if (!is.null(last_plot())) {
+    htmltools::htmlDependencies(html) <- NULL
   }
-  iframe <- plotly_iframe(src, width %||% l$width, height %||% l$height, url_ext = "")
-  get("display_html", envir = asNamespace("IRdisplay"))(iframe)
+  get("display_html", envir = asNamespace("IRdisplay"))(as.character(html))
 }
 
+# TODO: provide method for api_figure objects
+
+
 plotly_iframe <- function(url = "", width = NULL, height = NULL, url_ext = ".embed") {
   url <- paste0(url, url_ext)
   sprintf(