Skip to content

Commit 2f08cf8

Browse files
committed
Follow up to #2262: add a clarifying comment; update news
1 parent 4594408 commit 2f08cf8

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
* Closed #2216: Additional selectize.js options can now be passed along to `highlight()`'s `selectize` argument. (#2217)
66

7+
## Improvements
8+
9+
* Closed #2259: `ggplotly()` now provides better support for ggplot2 >v3.4.2. (#2262)
10+
711
## Bug fixes
812

913
* Closed #2212: `ggplotly()` no longer silently drops legends that are customized through `ggplot2::guide_legend()`.

R/layers2traces.R

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ layers2traces <- function(data, prestats_data, layout, p) {
103103
# now to the actual layer -> trace conversion
104104
trace.list <- list()
105105

106+
# ggplot2 >v3.4.2 (specifically #4879) moved the guides system to ggproto,
107+
# which moved the location of the name->value fields
106108
guides <- if (inherits(p$guides, "ggproto")) p$guides$guides else p$guides
107109
aes_no_guide <- names(guides)[vapply(guides, identical, logical(1), "none")]
108110

0 commit comments

Comments
 (0)