Skip to content

Commit 1fff3ca

Browse files
committed
Update news; add test
1 parent f9a791e commit 1fff3ca

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

NEWS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
* `ggplotly()` now converts `stat_ecdf()` properly. (#2065)
1111
* `ggplotly()` now correctly handles `geom_tile()` with no `fill` aesthetic. (#2063)
12-
12+
* Fixed an issue with translating `GGally::ggcorr()` via `ggplotly()`. (#2012)
1313

1414
# 4.10.0
1515

tests/testthat/test-plotly-subplot.R

+16-3
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,23 @@ test_that("subplot accepts a list of plots", {
134134
expect_true(l$layout[[sub("y", "yaxis", xaxes[[1]]$anchor)]]$domain[1] == 0)
135135
})
136136

137-
test_that("ggplotly understands ggmatrix", {
137+
test_that("ggplotly understands GGally", {
138138
skip_if_not_installed("GGally")
139-
L <- expect_doppelganger_built(GGally::ggpairs(iris),
140-
"plotly-subplot-ggmatrix")
139+
expect_doppelganger(
140+
GGally::ggpairs(iris),
141+
"plotly-subplot-ggmatrix"
142+
)
143+
d <- tibble::tibble(
144+
v1 = 1:100 + rnorm(100, sd = 20),
145+
v2 = 1:100 + rnorm(100, sd = 27),
146+
v3 = rep(1, 100) + rnorm(100, sd = 1),
147+
v4 = v1 ** 2,
148+
v5 = v1 ** 2
149+
)
150+
expect_doppelganger(
151+
ggcorr(data, method = c("everything", "pearson")),
152+
"ggally-ggcorr"
153+
)
141154
})
142155

143156
test_that("annotation paper repositioning", {

0 commit comments

Comments
 (0)