Merge pull request #367 from ropensci/feature/hovermode

set hovermode to closest for non-line scatter traces

Author: cpsievert

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: plotly
 Title: Create Interactive Web Graphics via Plotly's JavaScript Graphing Library
-Version: 2.1.3
+Version: 2.2.0
 Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
     email = "[email protected]"),
     person("Chris", "Parmer", role = c("aut", "cph"),

NEWS

@@ -1,3 +1,7 @@
+2.2.0 -- 13 Jan 2015
+
+The default for layout.hovermode is now 'closest' for non-line scatter traces
+
 2.1.3 -- 12 Jan 2015
 
 Fix size and alpha translation for geom_point. Fixes #386

R/plotly.R

@@ -353,6 +353,12 @@ plotly_build <- function(l = last_plot()) {
   }
   # traces shouldn't have any names
   x$data <- setNames(x$data, NULL)
+  # if this is a non-line scatter trace and no hovermode exists, 
+  # set hovermode to closest
+  if (is.null(x$data[[1]]$type) || isTRUE(x$data[[1]]$type == "scatter")) {
+    if (!grepl("lines", x$data[[1]]$mode %||% "lines"))
+      x$layout$hovermode <- x$layout$hovermode %||% "closest"
+  }
   # add plotly class mainly for printing method
   structure(x, class = unique("plotly", class(x)))
 }

tests/testthat/test-plotly-subplot.R

@@ -34,7 +34,8 @@ test_that("group + [x/y]axis works", {
   p <- plot_ly(iris, x = Petal.Length, y = Petal.Width, group = Species,
                xaxis = paste0("x", id), mode = "markers")
   s <- expect_traces(subplot(p, margin = 0.05), 3, "group")
-  doms <- lapply(s$layout, "[[", "domain")
+  ax <- s$layout[grepl("^[x-y]axis", names(s$layout))]
+  doms <- lapply(ax, "[[", "domain")
   # make sure y domain is [0, 1] on every axis
   ydom <- doms[grepl("^y", names(doms))]
   expect_equal(sort(unique(unlist(ydom))), c(0, 1))