fix bad error message for partial bundles and add a test

Author: cpsievert

R/partial_bundles.R

@@ -109,10 +109,9 @@ verify_partial_bundle <- function(p) {
   # (at this point, bundleType should never be 'auto' or 'main')
   missingTypes <- setdiff(types, bundleTraceMap[[bundleType]])
   if (length(missingTypes)) {
-    msg <- sprint(
-      "The '%s' bundle supports the following trace types: '%s'.\n\n",
-      "This plotly visualization contains the following trace types: '%s'",
-      bundle, paste(missingTypes, collapse = "', '"), paste(missingTypes, collapse = "', '")
+    msg <- sprintf(
+      "The '%s' bundle supports the following trace types: '%s'.\n\n This plotly visualization contains the following trace types: '%s'",
+      bundleType, paste(bundleTraceMap[[bundleType]], collapse = "', '"), paste(missingTypes, collapse = "', '")
     )
     stop(msg, call. = FALSE)
   }

tests/testthat/test-plotly-partial-bundles.R

@@ -37,6 +37,15 @@ test_that("Can find the right bundle", {
   )
 })
 
+test_that("Throws an informative error if wrong bundle is specified", {
+  p1 <- plot_ly(z = ~volcano) %>% add_heatmap()
+  
+  expect_error(
+    partial_bundle(p1, type = "basic"),
+    "The 'basic' bundle supports the following trace types: 'scatter', 'bar', 'pie'"
+  )
+})
+
 test_that("Can specify the partial bundle", {
   skip_on_cran()