plotly.js fix bug when crosstalk filter keys are null (#2087)

casperhart · web-flow · commit 01582b8f0517 · 2022-04-24T10:10:38.000-05:00
diff --git a/NEWS.md b/NEWS.md
@@ -15,6 +15,7 @@
 * `ggplotly()` now correctly handles `geom_tile()` with no `fill` aesthetic. (#2063)
 * `ggplotly()` now respects `guide(aes = "none")` (e.g., `guide(fill = "none")`) when constructing legend entries. (#2067)
 * Fixed an issue with translating `GGally::ggcorr()` via `ggplotly()`. (#2012)
+* Fixed an issue where clearing a crosstalk filter would raise an error in the JS console (#2087)
 
 ## Improvements
 
diff --git a/inst/htmlwidgets/plotly.js b/inst/htmlwidgets/plotly.js
@@ -616,9 +616,9 @@ TraceManager.prototype.updateFilter = function(group, keys) {
         traces.push(trace);
       }
     }
+    this.gd.data = traces;
   }
   
-  this.gd.data = traces;
   Plotly.redraw(this.gd);
   
   // NOTE: we purposely do _not_ restore selection(s), since on filter,

Original file line number	Diff line number	Diff line change
`@@ -616,9 +616,9 @@ TraceManager.prototype.updateFilter = function(group, keys) {`
`616`	`616`	`traces.push(trace);`
`617`	`617`	`}`
`618`	`618`	`}`
	`619`	`+ this.gd.data = traces;`
`619`	`620`	`}`
`620`	`621`
`621`		`- this.gd.data = traces;`
`622`	`622`	`Plotly.redraw(this.gd);`
`623`	`623`
`624`	`624`	`// NOTE: we purposely do _not_ restore selection(s), since on filter,`