In contrast to attr(x, unit), the new grid::unitType() function always return a vector the same length as it's input

cpsievert · cpsievert · commit 006b69a5d092 · 2019-11-07T10:54:20.000-06:00
diff --git a/R/ggplotly.R b/R/ggplotly.R
@@ -1137,8 +1137,8 @@ unitConvert <- function(u, to = c("npc", "pixels"), type = c("x", "y", "height",
 # from R, but it seems 96 is a reasonable assumption.
 mm2pixels <- function(u) {
   u <- verifyUnit(u)
-  if (getUnitType(u) != "mm") {
-    stop("Unit must be in millimeters")
+  if (any(getUnitType(u) != "mm")) {
+    stop("All units must be in millimeters")
   }
   (as.numeric(u) * 96) / 25.4
 }

Original file line number	Diff line number	Diff line change
`@@ -1137,8 +1137,8 @@ unitConvert <- function(u, to = c("npc", "pixels"), type = c("x", "y", "height",`
`1137`	`1137`	`# from R, but it seems 96 is a reasonable assumption.`
`1138`	`1138`	`mm2pixels <- function(u) {`
`1139`	`1139`	`u <- verifyUnit(u)`
`1140`		`- if (getUnitType(u) != "mm") {`
`1141`		`- stop("Unit must be in millimeters")`
	`1140`	`+ if (any(getUnitType(u) != "mm")) {`
	`1141`	`+ stop("All units must be in millimeters")`
`1142`	`1142`	`}`
`1143`	`1143`	`(as.numeric(u) * 96) / 25.4`
`1144`	`1144`	`}`