Skip to content

Angular 11 support #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moaxey opened this issue Mar 11, 2021 · 2 comments · Fixed by #156
Closed

Angular 11 support #154

moaxey opened this issue Mar 11, 2021 · 2 comments · Fixed by #156

Comments

@moaxey
Copy link

moaxey commented Mar 11, 2021

I guess this not trivial moving from @angular-devkit/build-ng-packagr to ng-packagr. Is anybody working on it?
@andrefarzat
Copy link
Collaborator

Hello @moaxey , at the beginning the library were published using ng-packagr, but since version 3.x and angular 10.x (I think) we are following the angular guide to library: https://angular.io/guide/creating-libraries

Is there a specific use case you need the ng-packagr ?

@thomaschampagne
Copy link

+1 for Angular 11 support 👍 😃 !

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^10.0.9" from [email protected]
npm ERR! node_modules/angular-plotly.js
npm ERR!   angular-plotly.js@"^3.0.0" from the root project

@andrefarzat andrefarzat mentioned this issue Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding angular >10.0 as peerDependency plotly/angular-plotly.js
3 participants
@thomaschampagne @moaxey @andrefarzat