Add Example for useReducer with types. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for delay got a really tough week, I'll get to it tomorrow. Cheers! |
piotrwitek
requested changes
Jan 20, 2019
playground/package.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "dependencies": { | |||
| "axios": "0.18.0", | |||
| "cuid": "2.1.1", | |||
| "react": "16.4.0", | |||
| "react": "^16.8.0-alpha.0", | |||
There was a problem hiding this comment.
Please correct all the added packages to use locked version
There was a problem hiding this comment.
@piotrwitek Sorry, I can't understand that what I should. How do I correct it to use the locked version?
There was a problem hiding this comment.
remove ^ prefix, everywhere you added them
playground/src/hooks/use-reducer.tsx
Outdated
| } | ||
|
|
||
| interface Action { | ||
| type: string; |
There was a problem hiding this comment.
should be an union, right now it's not type-safe
please declare:
type Action =
| { type: 'reset' }
| { type: 'increment' }
...
|
@piotrwitek I fixed the PR according to your review! please confirm:pray: |
piotrwitek
approved these changes
Jan 21, 2019
|
Yeah, that looks great! Thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #102
Caution
I installed
[email protected]and@types/[email protected]( and dependencies ) to use React Hooks.