Fix GH-14215: Cannot use FFI::load on CRLF header file with apache2handler

Some modules may reset _fmode, which causes mangling of line endings.
Always be explicit like we do in other places where the native open call
is used.

Closes GH-14218.

Author: nielsdos

NEWS

@@ -23,6 +23,10 @@ PHP                                                                        NEWS
   . Fix crash in ParentNode::append() when dealing with a fragment
     containing text nodes. (nielsdos)
 
+- FFI:
+  . Fixed bug GH-14215 (Cannot use FFI::load on CRLF header file with
+    apache2handler). (nielsdos)
+
 - FPM:
   . Fix bug GH-14175 (Show decimal number instead of scientific notation in
     systemd status). (Benjamin Cremer)

ext/ffi/ffi.c

@@ -3255,7 +3255,11 @@ static zend_ffi *zend_ffi_load(const char *filename, bool preload) /* {{{ */
 
 	code_size = buf.st_size;
 	code = emalloc(code_size + 1);
-	fd = open(filename, O_RDONLY, 0);
+	int open_flags = O_RDONLY;
+#ifdef PHP_WIN32
+	open_flags |= _O_BINARY;
+#endif
+	fd = open(filename, open_flags, 0);
 	if (fd < 0 || read(fd, code, code_size) != code_size) {
 		if (preload) {
 			zend_error(E_WARNING, "FFI: Failed pre-loading '%s', cannot read_file", filename);

ext/ffi/tests/gh14215.h

@@ -0,0 +1,3 @@
+#define FFI_LIB "Kernel32.dll"
+typedef unsigned long DWORD;
+DWORD GetLastError(void);

ext/ffi/tests/gh14215.phpt

@@ -0,0 +1,23 @@
+--TEST--
+GH-14215 (Cannot use FFI::load on CRLF header file with apache2handler)
+--EXTENSIONS--
+ffi
+zend_test
+--SKIPIF--
+<?php
+if(PHP_OS_FAMILY !== "Windows") {
+    die('skip only for Windows');
+}
+?>
+--INI--
+ffi.enable=1
+--FILE--
+<?php
+zend_test_set_fmode(false);
+$header_path = __DIR__.'\\gh14215.h';
+$ffi = FFI::load($header_path);
+var_dump($ffi->GetLastError());
+zend_test_set_fmode(true);
+?>
+--EXPECT--
+int(0)

ext/zend_test/test.c

@@ -584,6 +584,18 @@ static ZEND_FUNCTION(zend_test_is_pcre_bundled)
 #endif
 }
 
+#ifdef PHP_WIN32
+static ZEND_FUNCTION(zend_test_set_fmode)
+{
+	bool binary;
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_BOOL(binary)
+	ZEND_PARSE_PARAMETERS_END();
+
+	_fmode = binary ? _O_BINARY : _O_TEXT;
+}
+#endif
+
 static zend_object *zend_test_class_new(zend_class_entry *class_type)
 {
 	zend_object *obj = zend_objects_new(class_type);

ext/zend_test/test.stub.php

@@ -182,6 +182,10 @@ function zend_test_override_libxml_global_state(): void {}
 #endif
 
     function zend_test_is_pcre_bundled(): bool {}
+
+#if defined(PHP_WIN32)
+    function zend_test_set_fmode(bool $binary): void {}
+#endif
 }
 
 namespace ZendTestNS {