Skip to content

Commit e7da968

Browse files
devnexenweltling
authored andcommitted
Tidy extension update to be able to either use tidy or tidyp at configure time
1 parent 9318521 commit e7da968

File tree

3 files changed

+38
-9
lines changed

3 files changed

+38
-9
lines changed

ext/tidy/config.m4

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,19 @@ if test "$PHP_TIDY" != "no"; then
1414
fi
1515

1616
for i in $TIDY_SEARCH_DIRS; do
17-
if test -f $i/include/tidy/tidy.h; then
18-
TIDY_DIR=$i
19-
TIDY_INCDIR=$i/include/tidy
20-
elif test -f $i/include/tidy.h; then
21-
TIDY_DIR=$i
22-
TIDY_INCDIR=$i/include
23-
fi
17+
for j in tidy tidyp; do
18+
if test -f $i/include/$j/$j.h; then
19+
TIDY_DIR=$i
20+
TIDY_INCDIR=$i/include/$j
21+
TIDY_LIB_NAME=$j
22+
break
23+
elif test -f $i/include/$j.h; then
24+
TIDY_DIR=$i
25+
TIDY_INCDIR=$i/include
26+
TIDY_LIB_NAME=$j
27+
break
28+
fi
29+
done
2430
done
2531

2632
if test -z "$TIDY_DIR"; then
@@ -36,9 +42,14 @@ if test "$PHP_TIDY" != "no"; then
3642
fi
3743

3844
TIDY_LIBDIR=$TIDY_DIR/$PHP_LIBDIR
45+
if test "$TIDY_LIB_NAME" == 'tidyp'; then
46+
AC_DEFINE(HAVE_TIDYP_H,1,[defined if tidyp.h exists])
47+
else
48+
AC_DEFINE(HAVE_TIDY_H,1,[defined if tidy.h exists])
49+
fi
3950

40-
TIDY_LIB_NAME=tidy
41-
PHP_CHECK_LIBRARY(tidy,tidyOptGetDoc,
51+
52+
PHP_CHECK_LIBRARY($TIDY_LIB_NAME,tidyOptGetDoc,
4253
[
4354
AC_DEFINE(HAVE_TIDYOPTGETDOC,1,[ ])
4455
],[
@@ -49,6 +60,11 @@ if test "$PHP_TIDY" != "no"; then
4960
], [], [])
5061
],[])
5162

63+
PHP_CHECK_LIBRARY($TIDY_LIB_NAME,tidyReleaseDate,
64+
[
65+
AC_DEFINE(HAVE_TIDYRELEASEDATE,1,[ ])
66+
], [], [])
67+
5268
PHP_ADD_LIBRARY_WITH_PATH($TIDY_LIB_NAME, $TIDY_LIBDIR, TIDY_SHARED_LIBADD)
5369
PHP_ADD_INCLUDE($TIDY_INCDIR)
5470

ext/tidy/config.w32

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ if (PHP_TIDY != "no") {
1717

1818
EXTENSION("tidy", "tidy.c");
1919
AC_DEFINE('HAVE_TIDY', 1, 'Have TIDY library');
20+
AC_DEFINE('HAVE_TIDY_H', 1, "tidy include header")
2021
ADD_FLAG('CFLAGS_TIDY', '/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1');
2122
if (!PHP_TIDY_SHARED) {
2223
ADD_DEF_FILE("ext\\tidy\\php_tidy.def");

ext/tidy/tidy.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@
3030
#include "php_ini.h"
3131
#include "ext/standard/info.h"
3232

33+
#if HAVE_TIDY_H
3334
#include "tidy.h"
35+
#elif HAVE_TIDYP_H
36+
#include "tidyp.h"
37+
#endif
3438

3539
#if HAVE_TIDYBUFFIO_H
3640
#include "tidybuffio.h"
@@ -1073,8 +1077,12 @@ static PHP_MINFO_FUNCTION(tidy)
10731077
php_info_print_table_header(2, "Tidy support", "enabled");
10741078
#if HAVE_TIDYBUFFIO_H
10751079
php_info_print_table_row(2, "libTidy Version", (char *)tidyLibraryVersion());
1080+
#elif HAVE_TIDYP_H
1081+
php_info_print_table_row(2, "libTidy Version", (char *)tidyVersion());
10761082
#endif
1083+
#if HAVE_TIDYRELEASEDATE
10771084
php_info_print_table_row(2, "libTidy Release", (char *)tidyReleaseDate());
1085+
#endif
10781086
php_info_print_table_row(2, "Extension Version", PHP_TIDY_VERSION " ($Id$)");
10791087
php_info_print_table_end();
10801088

@@ -1342,7 +1350,11 @@ static PHP_FUNCTION(tidy_get_release)
13421350
return;
13431351
}
13441352

1353+
#if HAVE_TIDYRELEASEDATE
13451354
RETURN_STRING((char *)tidyReleaseDate());
1355+
#else
1356+
RETURN_STRING((char *)"unknown");
1357+
#endif
13461358
}
13471359
/* }}} */
13481360

0 commit comments

Comments
 (0)