Skip to content

Commit d9eb378

Browse files
authored
1 parent 77ad57c commit d9eb378

File tree

5 files changed

+6
-28
lines changed

5 files changed

+6
-28
lines changed

NEWS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ PHP NEWS
1414
. Fixed bug GH-15192 (Segmentation fault in dom extension
1515
(html5_serializer)). (nielsdos)
1616
. Deprecated DOM_PHP_ERR constant. (nielsdos)
17+
. Removed DOMImplementation::getFeature(). (nielsdos)
1718

1819
- PHPDBG:
1920
. array out of bounds, stack overflow handled for segfault handler on windows.

UPGRADING

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,10 @@ PHP 8.4 UPGRADE NOTES
761761
- Date:
762762
. The class constants are typed now.
763763

764+
- DOM:
765+
. Removed DOMImplementation::getFeature().
766+
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#remove_domimplementationgetfeature_feature_version
767+
764768
- Intl:
765769
. The class constants are typed now.
766770
. The behaviour of Intl class has been normalized to always throw Error

ext/dom/domimplementation.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -415,21 +415,4 @@ PHP_METHOD(Dom_Implementation, createHTMLDocument)
415415
}
416416
/* }}} */
417417

418-
/* {{{ URL: http://www.w3.org/TR/2003/WD-DOM-Level-3-Core-20030226/DOM3-Core.html#DOMImplementation3-getFeature
419-
Since: DOM Level 3
420-
*/
421-
PHP_METHOD(DOMImplementation, getFeature)
422-
{
423-
size_t feature_len, version_len;
424-
char *feature, *version;
425-
426-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss", &feature, &feature_len, &version, &version_len) == FAILURE) {
427-
RETURN_THROWS();
428-
}
429-
430-
zend_throw_error(NULL, "Not yet implemented");
431-
RETURN_THROWS();
432-
}
433-
/* }}} end dom_domimplementation_get_feature */
434-
435418
#endif

ext/dom/php_dom.stub.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,6 @@ public function __wakeup(): void {}
454454

455455
class DOMImplementation
456456
{
457-
/** @tentative-return-type */
458-
public function getFeature(string $feature, string $version): never {}
459-
460457
/** @tentative-return-type */
461458
public function hasFeature(string $feature, string $version): bool {}
462459

ext/dom/php_dom_arginfo.h

Lines changed: 1 addition & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)