Skip to content

Commit ba19cc7

Browse files
committed
Merge remote-tracking branch 'origin/PHP-5.6' into str_size_and_int64_56_backport
* origin/PHP-5.6: Added further notice about removal of IS_CONSTANT_INDEX/ARRAY macros Fix bug #67060: use default mode of 660
2 parents 0f42656 + 82ecdcd commit ba19cc7

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ PHP NEWS
4545
. Fixed bug #66482 (unknown entry 'priority' in php-fpm.conf).
4646
. Fixed bug #66908 (php-fpm reload leaks epoll_create() file descriptor).
4747
(Julio Pintos)
48+
. Fixed bug #67060 (sapi/fpm: possible privilege escalation due to insecure
49+
default configuration) (CVE-2014-0185). (Stas)
4850

4951
- GMP:
5052
. Fixed crashes in serialize/unserialize. (Stas)

UPGRADING.INTERNALS

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ UPGRADE NOTES - PHP X.Y
1414
i. Addition of zend_hash_splice
1515
j. An additional parameter is sent to Countable::count()
1616
k. Unserialization of manipulated object strings
17+
l. Removal of IS_CONSTANT_ARRAY and IS_CONSTANT_INDEX hack
1718

1819
2. Build system changes
1920
a. Unix build system changes
@@ -206,6 +207,15 @@ UPGRADE NOTES - PHP X.Y
206207
fixed at the appropriate place by checking for the presence of the
207208
serialize callback in the class entry.
208209

210+
l. Removal of IS_CONSTANT_ARRAY and IS_CONSTANT_INDEX hack
211+
212+
These two #defines disappeared. Instead we have now IS_CONSTANT_AST which
213+
covers also the functionality IS_CONSTANT_ARRAY bid and furthermore the
214+
hack for marking zvals as constant index with IS_CONSTANT_INDEX is now
215+
superfluous and so removed.
216+
Please note that IS_CONSTANT_AST now has the same value than
217+
IS_CONSTANT_ARRAY had.
218+
209219
========================
210220
2. Build system changes
211221
========================

sapi/fpm/fpm/fpm_unix.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ int fpm_unix_resolve_socket_premissions(struct fpm_worker_pool_s *wp) /* {{{ */
3939
/* uninitialized */
4040
wp->socket_uid = -1;
4141
wp->socket_gid = -1;
42-
wp->socket_mode = 0666;
42+
wp->socket_mode = 0660;
4343

4444
if (!c) {
4545
return 0;

sapi/fpm/php-fpm.conf.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,10 @@ listen = 127.0.0.1:9000
166166
; permissions must be set in order to allow connections from a web server. Many
167167
; BSD-derived systems allow connections regardless of permissions.
168168
; Default Values: user and group are set as the running user
169-
; mode is set to 0666
169+
; mode is set to 0660
170170
;listen.owner = @php_fpm_user@
171171
;listen.group = @php_fpm_group@
172-
;listen.mode = 0666
172+
;listen.mode = 0660
173173

174174
; List of ipv4 addresses of FastCGI clients which are allowed to connect.
175175
; Equivalent to the FCGI_WEB_SERVER_ADDRS environment variable in the original

0 commit comments

Comments
 (0)