Skip to content

Commit a5749eb

Browse files
committed
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: Fixed Bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer
2 parents 4e3de60 + d69513a commit a5749eb

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ext/date/php_date.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2198,13 +2198,13 @@ static HashTable *date_object_get_properties(zval *object TSRMLS_DC)
21982198
/* first we add the date and time in ISO format */
21992199
MAKE_STD_ZVAL(zv);
22002200
ZVAL_STRING(zv, date_format("Y-m-d H:i:s", 12, dateobj->time, 1), 0);
2201-
zend_hash_update(props, "date", 5, &zv, sizeof(zval), NULL);
2201+
zend_hash_update(props, "date", 5, &zv, sizeof(zv), NULL);
22022202

22032203
/* then we add the timezone name (or similar) */
22042204
if (dateobj->time->is_localtime) {
22052205
MAKE_STD_ZVAL(zv);
22062206
ZVAL_LONG(zv, dateobj->time->zone_type);
2207-
zend_hash_update(props, "timezone_type", 14, &zv, sizeof(zval), NULL);
2207+
zend_hash_update(props, "timezone_type", 14, &zv, sizeof(zv), NULL);
22082208

22092209
MAKE_STD_ZVAL(zv);
22102210
switch (dateobj->time->zone_type) {
@@ -2227,7 +2227,7 @@ static HashTable *date_object_get_properties(zval *object TSRMLS_DC)
22272227
ZVAL_STRING(zv, dateobj->time->tz_abbr, 1);
22282228
break;
22292229
}
2230-
zend_hash_update(props, "timezone", 9, &zv, sizeof(zval), NULL);
2230+
zend_hash_update(props, "timezone", 9, &zv, sizeof(zv), NULL);
22312231
}
22322232

22332233
return props;
@@ -2394,7 +2394,7 @@ static HashTable *date_object_get_properties_interval(zval *object TSRMLS_DC)
23942394
#define PHP_DATE_INTERVAL_ADD_PROPERTY(n,f) \
23952395
MAKE_STD_ZVAL(zv); \
23962396
ZVAL_LONG(zv, (long)intervalobj->diff->f); \
2397-
zend_hash_update(props, n, strlen(n) + 1, &zv, sizeof(zval), NULL);
2397+
zend_hash_update(props, n, strlen(n) + 1, &zv, sizeof(zv), NULL);
23982398

23992399
PHP_DATE_INTERVAL_ADD_PROPERTY("y", y);
24002400
PHP_DATE_INTERVAL_ADD_PROPERTY("m", m);
@@ -2411,7 +2411,7 @@ static HashTable *date_object_get_properties_interval(zval *object TSRMLS_DC)
24112411
} else {
24122412
MAKE_STD_ZVAL(zv);
24132413
ZVAL_FALSE(zv);
2414-
zend_hash_update(props, "days", 5, &zv, sizeof(zval), NULL);
2414+
zend_hash_update(props, "days", 5, &zv, sizeof(zv), NULL);
24152415
}
24162416
PHP_DATE_INTERVAL_ADD_PROPERTY("special_type", special.type);
24172417
PHP_DATE_INTERVAL_ADD_PROPERTY("special_amount", special.amount);

0 commit comments

Comments
 (0)