Skip to content

Commit 9f591c9

Browse files
committed
Revert "Throw on negative setcookie expiration timestamp"
This reverts commit 82dfd93.
1 parent 486fb80 commit 9f591c9

File tree

4 files changed

+0
-39
lines changed

4 files changed

+0
-39
lines changed

NEWS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ PHP NEWS
130130
. password_hash() will now chain the original RandomException to the ValueError
131131
on salt generation failure. (timwolla)
132132
. Fix GH-10239 (proc_close after proc_get_status always returns -1). (nielsdos)
133-
. Fix GH-10765 (Throw on negative setcookie expiration date). (ilutov)
134133

135134
- Streams:
136135
. Fixed bug #51056: blocking fread() will block even if data is available.

Zend/tests/gh10765_1.phpt

Lines changed: 0 additions & 17 deletions
This file was deleted.

Zend/tests/gh10765_2.phpt

Lines changed: 0 additions & 17 deletions
This file was deleted.

ext/standard/head.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,6 @@ PHPAPI zend_result php_setcookie(zend_string *name, zend_string *value, time_t e
117117
return FAILURE;
118118
}
119119
#endif
120-
if (UNEXPECTED(expires < 0)) {
121-
zend_value_error("%s(): \"expires\" option must be greater than or equal to 0", get_active_function_name());
122-
return FAILURE;
123-
}
124120

125121
/* Should check value of SameSite? */
126122

0 commit comments

Comments
 (0)