Skip to content

Commit 901d022

Browse files
committed
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3: Fix #78470: odbc_specialcolumns() no longer accepts $nullable
2 parents a89ac98 + 610e7d2 commit 901d022

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ PHP NEWS
1414
. Fixed bug #80107 (mysqli_query() fails for ~16 MB long query when
1515
compression is enabled). (Nikita)
1616

17+
- ODBC:
18+
. Fixed bug #78470 (odbc_specialcolumns() no longer accepts $nullable). (cmb)
19+
1720
- OPcache:
1821
. Fixed bug #80083 (Optimizer pass 6 removes variables used for ibm_db2 data
1922
binding). (Nikita)

ext/odbc/php_odbc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3667,7 +3667,7 @@ PHP_FUNCTION(odbc_specialcolumns)
36673667
SQLUSMALLINT type, scope, nullable;
36683668
RETCODE rc;
36693669

3670-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "rls!ssl", &pv_conn, &vtype, &cat, &cat_len, &schema, &schema_len,
3670+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "rls!ssll", &pv_conn, &vtype, &cat, &cat_len, &schema, &schema_len,
36713671
&name, &name_len, &vscope, &vnullable) == FAILURE) {
36723672
return;
36733673
}

ext/odbc/tests/bug78470.phpt

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
--TEST--
2+
Bug #78470 (odbc_specialcolumns() no longer accepts $nullable)
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded('odbc')) die('skip odbc extension not available');
6+
?>
7+
--FILE--
8+
<?php
9+
include 'config.inc';
10+
11+
$conn = odbc_connect($dsn, $user, $pass);
12+
var_dump(odbc_specialcolumns($conn, SQL_BEST_ROWID, '', '', '', SQL_SCOPE_CURROW, SQL_NO_NULLS));
13+
?>
14+
--EXPECTF--
15+
resource(%d) of type (odbc result)

0 commit comments

Comments
 (0)