Deprecate DOM_PHP_ERR (#15234)

* Deprecate DOM_PHP_ERR

RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_dom_php_err_constant

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <[email protected]>

---------

Co-authored-by: Tim Düsterhus <[email protected]>

Author: nielsdos

NEWS

@@ -13,6 +13,7 @@ PHP                                                                        NEWS
 - DOM:
   . Fixed bug GH-15192 (Segmentation fault in dom extension
     (html5_serializer)). (nielsdos)
+  . Deprecated DOM_PHP_ERR constant. (nielsdos)
 
 - PHPDBG:
   . array out of bounds, stack overflow handled for segfault handler on windows.

UPGRADING

@@ -409,6 +409,10 @@ PHP 8.4 UPGRADE NOTES
     the associated date_sunset() and date_sunrise() functions in PHP 8.1.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_4
 
+- DOM:
+  . Deprecated DOM_PHP_ERR constant.
+    RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_dom_php_err_constant
+
 - Intl:
   . Calling intlcal_set() as well as calling IntlCalendar::set() with
     more than 2 arguments is deprecated. Use either IntlCalendar::setDate()

ext/dom/php_dom.stub.php

@@ -147,6 +147,7 @@
 
     /**
      * @var int
+     * @deprecated is no longer used since 8.4
      * @cvalue PHP_ERR
      */
     const DOM_PHP_ERR = UNKNOWN;

ext/dom/php_dom_arginfo.h

@@ -0,0 +1,11 @@
+--TEST--
+Test deprecation emitted on accessing DOM_PHP_ERR
+--EXTENSIONS--
+dom
+--FILE--
+<?php
+var_dump(DOM_PHP_ERR);
+?>
+--EXPECTF--
+Deprecated: Constant DOM_PHP_ERR is deprecated in %s on line %d
+int(0)