Skip to content

Make resulting files pass flake8 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kirsanium opened this issue Oct 12, 2022 · 3 comments
Closed

Make resulting files pass flake8 #29

kirsanium opened this issue Oct 12, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request lang/python
Milestone

Comments

@kirsanium
Copy link
Contributor

В настоящий момент есть проблемы с линтингом нагенерированных файлов:

  • пробелы вокруг = в именнованных параметрах
  • SQL запрос в одну строку - превышает длину строки в 120 символов
@php-coder php-coder changed the title Make resulting files pass flake8 [python] Make resulting files pass flake8 Oct 13, 2022
@php-coder
Copy link
Owner

SQL запрос в одну строку - превышает длину строки в 120 символов

Будет исправлено вместе с #26

@php-coder
Copy link
Owner

Выхлоп на текущем примере:

$ flake8 . --max-line-length 120                                                                                                                                                   9:36
./routes.py:9:1: E302 expected 2 blank lines, found 1
./routes.py:11:17: E251 unexpected spaces around keyword / parameter equals
./routes.py:11:19: E251 unexpected spaces around keyword / parameter equals
./routes.py:12:13: E251 unexpected spaces around keyword / parameter equals
./routes.py:12:15: E251 unexpected spaces around keyword / parameter equals
./routes.py:13:17: E251 unexpected spaces around keyword / parameter equals
./routes.py:13:19: E251 unexpected spaces around keyword / parameter equals
./routes.py:14:13: E251 unexpected spaces around keyword / parameter equals
./routes.py:14:15: E251 unexpected spaces around keyword / parameter equals
./routes.py:15:13: E251 unexpected spaces around keyword / parameter equals
./routes.py:15:15: E251 unexpected spaces around keyword / parameter equals
./routes.py:19:33: E251 unexpected spaces around keyword / parameter equals
./routes.py:19:35: E251 unexpected spaces around keyword / parameter equals
./routes.py:22:44: E251 unexpected spaces around keyword / parameter equals
./routes.py:22:46: E251 unexpected spaces around keyword / parameter equals
./routes.py:31:1: E302 expected 2 blank lines, found 1
./routes.py:32:32: E251 unexpected spaces around keyword / parameter equals
./routes.py:32:34: E251 unexpected spaces around keyword / parameter equals
./routes.py:35:44: E251 unexpected spaces around keyword / parameter equals
./routes.py:35:46: E251 unexpected spaces around keyword / parameter equals
./routes.py:49:1: E302 expected 2 blank lines, found 1
./routes.py:50:73: E251 unexpected spaces around keyword / parameter equals
./routes.py:50:75: E251 unexpected spaces around keyword / parameter equals
./routes.py:53:44: E251 unexpected spaces around keyword / parameter equals
./routes.py:53:46: E251 unexpected spaces around keyword / parameter equals
./routes.py:61:27: E201 whitespace after '{'
./routes.py:61:56: E202 whitespace before '}'
./routes.py:69:1: E302 expected 2 blank lines, found 1
./routes.py:70:39: E251 unexpected spaces around keyword / parameter equals
./routes.py:70:41: E251 unexpected spaces around keyword / parameter equals
./routes.py:73:44: E251 unexpected spaces around keyword / parameter equals
./routes.py:73:46: E251 unexpected spaces around keyword / parameter equals
./routes.py:82:27: E201 whitespace after '{'
./routes.py:82:42: E202 whitespace before '}'
./routes.py:87:1: E302 expected 2 blank lines, found 1
./routes.py:91:1: E302 expected 2 blank lines, found 1
./routes.py:92:51: E251 unexpected spaces around keyword / parameter equals
./routes.py:92:53: E251 unexpected spaces around keyword / parameter equals
./routes.py:95:44: E251 unexpected spaces around keyword / parameter equals
./routes.py:95:46: E251 unexpected spaces around keyword / parameter equals
./routes.py:104:27: E201 whitespace after '{'
./routes.py:104:52: E202 whitespace before '}'
./routes.py:112:1: E302 expected 2 blank lines, found 1
./routes.py:116:1: E302 expected 2 blank lines, found 1
./routes.py:119:1: W391 blank line at end of file

@php-coder php-coder self-assigned this Oct 13, 2022
@php-coder php-coder added this to the 0.0.3 milestone Oct 13, 2022
@php-coder php-coder added the enhancement New feature or request label Oct 13, 2022
@php-coder
Copy link
Owner

Интересно, что примеры от FastAPI не соответствуют flake8: https://fastapi.tiangolo.com/tutorial/dependencies/

async def read_items(commons: dict = Depends(common_parameters)):

@php-coder php-coder changed the title [python] Make resulting files pass flake8 Make resulting files pass flake8 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lang/python
Projects
None yet
Development

No branches or pull requests

2 participants