Skip to content

Add to collection: add integration test for specifying a price #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0pdd opened this issue Jun 16, 2018 · 2 comments
Open

Add to collection: add integration test for specifying a price #883

0pdd opened this issue Jun 16, 2018 · 2 comments
Labels
area/integration tests techdebt

Comments

@0pdd
Copy link

0pdd commented Jun 16, 2018 •
edited by php-coder
Loading

The puzzle 663-2b32ef86 from #663 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/controller/dto/AddToCollectionForm.java

Line 36 in fc7e116

// @todo #663 Add to collection: add integration test for specifying a price

The puzzle was created by Slava Semushin on 15-Jun-18.
@0pdd 0pdd added the techdebt label Jun 16, 2018
0pdd referenced this issue Jun 16, 2018
@php-coder
User can specify a price that he/she paid for a series.
fc7e116 
Fix #663
@0pdd 0pdd mentioned this issue Jun 16, 2018
Closed
@php-coder
Copy link
Owner

It should be available only for paid users. Also, we probably should have 2 sets of tests (one for paid users and another one for ordinary users).

@php-coder
Copy link
Owner

P.S. don't forget to test that price/currency fields are disabled for non-paid users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integration tests techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @0pdd