Skip to content

SiteParser: reduce duplication between extractQuantity() and extractPerforated() #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Jan 2, 2018 · 1 comment
Closed

SiteParser: reduce duplication between extractQuantity() and extractPerforated() #796

0pdd opened this issue Jan 2, 2018 · 1 comment
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Jan 2, 2018

The puzzle 782-0f02d25e from #782 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/util/extractor/SiteParser.java

Line 230 in 35bc274

// @todo #782 SiteParser: reduce duplication between extractQuantity() and extractPerforated()

The puzzle was created by Slava Semushin on 01-Jan-18.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Jan 2, 2018
0pdd referenced this issue Jan 2, 2018
@php-coder
SeriesInfoExtractorServiceImpl.extractQuantity(): add more logging.
35bc274 
Should be in 3651fd9 commit.

Addressed to #781

No functional changes.
@php-coder php-coder self-assigned this Jan 2, 2018
@0pdd
Copy link
Author

0pdd commented Jan 2, 2018

The puzzle 782-0f02d25e has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Jan 2, 2018
@php-coder php-coder added this to the 0.4 milestone Jan 2, 2018
0pdd referenced this issue Jan 2, 2018
@php-coder
JsoupSiteParser.getTextOfTheFirstElement(): introduce method to reduc…
44c3e73 
…e duplication between extractQuantity() and extractPerforated().

Fix #782

No functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd