Skip to content

Series import: validate URL for a length after encoding it to percent encoding #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Jan 1, 2018 · 2 comments
Open

Series import: validate URL for a length after encoding it to percent encoding #792

php-coder opened this issue Jan 1, 2018 · 2 comments
Labels
area/validation techdebt

Comments

@php-coder
Copy link
Owner

Follow-up to #772 -- at this time it's possible to provide such a url that will pass the validation but won't be persisted because it gets longer after encoding it to the percent encoding.
@php-coder
Copy link
Owner Author

We could try to use a field of type URI. We could try to use filters that are being executed before validation.

Also we should adjust constant in ValidationRules (and integration tests) as now it's possible to provide a longer URL.

@php-coder
Copy link
Owner Author

Also we should adjust constant in ValidationRules (and integration tests) as now it's possible to provide a longer URL.

Fixed in f8eee29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/validation techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@php-coder