Skip to content

SeriesInfoExtractorServiceImpl.extractReleaseYear() shouldn't return year in future #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Jan 1, 2018 · 1 comment
Open

SeriesInfoExtractorServiceImpl.extractReleaseYear() shouldn't return year in future #787

php-coder opened this issue Jan 1, 2018 · 1 comment
Assignees
@php-coder
Labels
kind/improvement
Milestone
next

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 1, 2018 •
edited
Loading

At present, our regexp matches years till 2099:

mystamps/src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java

Lines 37 to 42 in 0df664c

// Related to RELEASE_YEAR_REGEXP and used in unit tests.
protected static final int MAX_SUPPORTED_RELEASE_YEAR = 2099;
// Regular expression matches release year of the stamps (from 1840 till 2099).
private static final Pattern RELEASE_YEAR_REGEXP =
Pattern.compile("18[4-9][0-9]|19[0-9]{2}|20[0-9]{2}");

We shouldn't return year if it's in future.
@php-coder
Copy link
Owner Author

Related to #693

@php-coder php-coder added this to the 0.4 milestone Jul 15, 2018
@php-coder php-coder self-assigned this Jul 16, 2018
@php-coder php-coder modified the milestones: 0.4, next Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder