Skip to content

Series sales form: don't allow to submit alternative price without currency #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Oct 31, 2017 · 3 comments
Closed

Comments

@php-coder
Copy link
Owner

Regression after #675

@php-coder php-coder added this to the next milestone Oct 31, 2017
@php-coder php-coder modified the milestones: next, 0.4 Jun 17, 2018
@php-coder php-coder self-assigned this Feb 28, 2019
@php-coder php-coder modified the milestones: next, 0.4 Feb 28, 2019
@php-coder
Copy link
Owner Author

We don't have any affected records

mysql> select count(*) from series_sales where second_price is not null and second_currency is null;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

so I'm going to just fix this bug without migrating existing data.

@php-coder
Copy link
Owner Author

There is similar bug when it's possible to specify alternative currency only. It won't be shown to user but will be written to database. There are no affected records, and I'm going to fix both bugs as part of this issue.

@0pdd
Copy link

0pdd commented Mar 1, 2019

@php-coder the puzzle #1011 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants