Skip to content

Get rid of usrz/bootstrap-languages dependency #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Oct 22, 2015 · 8 comments
Open

Get rid of usrz/bootstrap-languages dependency #246

php-coder opened this issue Oct 22, 2015 · 8 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/infrastructure area/markup area/optimization This change could speed up our site techdebt
Milestone
0.5

Comments

@php-coder
Copy link
Owner

Right now we're using usrz/bootstrap-languages from http://rawgit.com but we need to have it as a WebJar (especially as classic webjar, see webjars/webjars#1185).

Tech debt for e567018 (#216)
@php-coder php-coder added this to the next milestone Jul 29, 2016
@php-coder
Copy link
Owner Author

Because of using external service, integration tests fail when they're running offline.

@php-coder
Copy link
Owner Author

Now I have a better idea -- don't use it at all :) We need only 2 tiny images with country flags and that's all. We can even embed these images in the page sources and don't load 2 external files (css/image).

@php-coder php-coder modified the milestones: 0.5, next May 17, 2017
@php-coder php-coder added the area/optimization This change could speed up our site label Aug 25, 2017
@php-coder
Copy link
Owner Author

It turned out that loading of the https://cdn.rawgit.com/usrz/bootstrap-languages/3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.png leads to a redirect to
https://raw.githubusercontent.com/usrz/bootstrap-languages/3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.png

@php-coder php-coder modified the milestones: 0.4, 0.5 Aug 25, 2017
@php-coder php-coder self-assigned this Aug 25, 2017
@php-coder php-coder changed the title Use usrz/bootstrap-languages from webjars Get rid of usrz/bootstrap-languages dependency Aug 25, 2017
@php-coder
Copy link
Owner Author

Don't forget to update CSP rules that were added in 4d0922e

@php-coder php-coder modified the milestones: 0.4, next Jun 13, 2018
@php-coder
Copy link
Owner Author

rawgit.com is End Of Life and should be replaced.

@php-coder
Copy link
Owner Author

rawgit.com is End Of Life and should be replaced.

We can temporary move to jsdelivr: https://www.jsdelivr.com/rawgit

@php-coder
Copy link
Owner Author

We can temporary move to jsdelivr: https://www.jsdelivr.com/rawgit

Done in 4cfa56e commit.

@php-coder php-coder modified the milestones: next, 0.4.1 May 27, 2019
@php-coder php-coder modified the milestones: 0.4.1, 0.5 Aug 27, 2019
@php-coder
Copy link
Owner Author

Perhaps, we can take flags from https://www.gosquared.com/resources/flag-icons/

@php-coder php-coder modified the milestones: 0.5, next Apr 3, 2020
@php-coder php-coder removed this from the next milestone Jan 12, 2021
@php-coder php-coder added this to the 0.4.6 milestone Jan 12, 2021
@php-coder php-coder modified the milestones: 0.4.6, 0.4.7 Feb 1, 2021
@php-coder php-coder modified the milestones: 0.4.7, 0.5 Oct 18, 2021
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Nov 29, 2023
@php-coder php-coder mentioned this issue Mar 1, 2024
Open
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/infrastructure area/markup area/optimization This change could speed up our site techdebt
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@php-coder