Skip to content

SeriesSaleImportForm: wait until setState() finishes #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0pdd opened this issue Jul 11, 2019 · 3 comments
Open

SeriesSaleImportForm: wait until setState() finishes #1074

0pdd opened this issue Jul 11, 2019 · 3 comments
Labels
area/frontend refactoring techdebt

Comments

@0pdd
Copy link

0pdd commented Jul 11, 2019 •
edited by php-coder
Loading

The puzzle 1057-ea0a43ea from #1057 has to be resolved:

mystamps/src/main/frontend/src/components/SeriesSaleImportForm.js

Line 35 in 6b40dca

// @todo #1057 SeriesSaleImportForm: wait until setState() finishes

The puzzle was created by Slava Semushin on 23-Jun-19.
@0pdd 0pdd added the techdebt label Jul 11, 2019
0pdd referenced this issue Jul 11, 2019
@php-coder
refactor: port import series sale form to React.
6b40dca 
Fix #1057
@0pdd 0pdd mentioned this issue Jul 11, 2019
Closed
@php-coder
Copy link
Owner

The same should be done for SimilarSeriesForm.js that has been added in 1391152 (#1280)

@php-coder php-coder mentioned this issue Jul 9, 2022
Closed
@0pdd 0pdd closed this as completed Sep 3, 2022
@0pdd
Copy link
Author

0pdd commented Sep 3, 2022

The puzzle 1057-ea0a43ea has disappeared from the source code, that's why I closed this issue.

0pdd referenced this issue Sep 3, 2022
@php-coder
add first action
491b42c
@php-coder
Copy link
Owner

The puzzle is still here:

$ git grep -1 '@todo #1057 SeriesSaleImportForm: wait until setState() finishes'
src/main/frontend/src/components/SeriesSaleImportForm.js-
src/main/frontend/src/components/SeriesSaleImportForm.js:               // @todo #1057 SeriesSaleImportForm: wait until setState() finishes
src/main/frontend/src/components/SeriesSaleImportForm.js-               // (see https://reactjs.org/docs/react-component.html#setstate)

@php-coder php-coder reopened this Sep 5, 2022
@php-coder php-coder mentioned this issue Sep 5, 2022
Open
@php-coder php-coder mentioned this issue Jan 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend refactoring techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @0pdd