test(SeriesServiceImpl.findSimilarSeries): add unit tests.

Fix #992

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/SeriesServiceImpl.java

@@ -289,7 +289,6 @@ public List<SeriesLinkDto> findRecentlyAdded(int quantity, String lang) {
 		return seriesDao.findLastAdded(quantity, lang);
 	}
 
-	// @todo #967 SeriesServiceImpl.findSimilarSeries(): add unit tests
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesLinkDto> findSimilarSeries(Integer seriesId, String lang) {

src/test/groovy/ru/mystamps/web/feature/series/SeriesServiceImplTest.groovy

@@ -1095,6 +1095,32 @@ class SeriesServiceImplTest extends Specification {
 			1 * seriesDao.findLastAdded(expectedQuantity, expectedLang) >> []
 	}
 
+	//
+	// Tests for findSimilarSeries()
+	//
+	
+	def 'findSimilarSeries() should throw exception when series id is null'() {
+		when:
+			service.findSimilarSeries(null, Random.lang())
+		then:
+			IllegalArgumentException ex = thrown()
+			ex.message == 'Series id must be non null'
+	}
+	
+	def 'findSimilarSeries() should invoke dao, pass arguments and return result from dao'() {
+		given:
+			Integer expectedSeriesId = Random.id()
+			String expectedLang = Random.lang()
+		and:
+			List<SeriesLinkDto> expectedResult = [ TestObjects.createSeriesLinkDto() ]
+		when:
+			List<SeriesLinkDto> result = service.findSimilarSeries(expectedSeriesId, expectedLang)
+		then:
+			1 * seriesDao.findSimilarSeries(expectedSeriesId, expectedLang) >> expectedResult
+		and:
+			result == expectedResult
+	}
+	
 	//
 	// Tests for findAllForSitemap()
 	//

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -41,6 +41,7 @@
 import ru.mystamps.web.feature.series.PurchaseAndSaleDto;
 import ru.mystamps.web.feature.series.SeriesFullInfoDto;
 import ru.mystamps.web.feature.series.SeriesInfoDto;
+import ru.mystamps.web.feature.series.SeriesLinkDto;
 import ru.mystamps.web.feature.series.SitemapInfoDto;
 import ru.mystamps.web.feature.series.importing.ImportRequestDto;
 import ru.mystamps.web.feature.series.importing.ImportRequestFullInfo;
@@ -413,4 +414,14 @@ public static AddToCollectionForm createAddToCollectionForm() {
 		return dto;
 	}
 
+	public static SeriesLinkDto createSeriesLinkDto() {
+		return new SeriesLinkDto(
+			Random.id(),
+			Random.issueYear(),
+			Random.quantity(),
+			Random.perforated(),
+			Random.countryName()
+		);
+	}
+	
 }