refactor: improve a test by checking an error message

php-coder · php-coder · commit eadae9766a07 · 2021-01-30T22:28:05.000+07:00
diff --git a/src/test/groovy/ru/mystamps/web/feature/series/SeriesServiceImplTest.groovy b/src/test/groovy/ru/mystamps/web/feature/series/SeriesServiceImplTest.groovy
@@ -693,7 +693,8 @@ class SeriesServiceImplTest extends Specification {
 		when:
 			service.findFullInfoById(null, null, bool())
 		then:
-			thrown(IllegalArgumentException)
+			IllegalArgumentException ex = thrown()
+			ex.message == 'Series id must be non null'
 	}
 	
 	def "findFullInfoById() should return null when series not found"() {

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,8 @@ class SeriesServiceImplTest extends Specification {`
`693`	`693`	`when:`
`694`	`694`	`service.findFullInfoById(null, null, bool())`
`695`	`695`	`then:`
`696`		`- thrown(IllegalArgumentException)`
	`696`	`+ IllegalArgumentException ex = thrown()`
	`697`	`+ ex.message == 'Series id must be non null'`
`697`	`698`	`}`
`698`	`699`
`699`	`700`	`def "findFullInfoById() should return null when series not found"() {`