Skip to content

Commit d73800d

Browse files
committed
Support search by Zagorski number.
Fix #776
1 parent 57f918b commit d73800d

File tree

6 files changed

+22
-2
lines changed

6 files changed

+22
-2
lines changed

src/main/java/ru/mystamps/web/config/DaoConfig.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ public StampsCatalogDao getZagorskiCatalogDao() {
157157
jdbcTemplate,
158158
env.getRequiredProperty("zagorski.create"),
159159
env.getRequiredProperty("series_zagorski.add"),
160-
env.getRequiredProperty("series_zagorski.find_by_series_id")
160+
env.getRequiredProperty("series_zagorski.find_by_series_id"),
161+
env.getRequiredProperty("series_zagorski.find_series_ids_by_number")
161162
);
162163
}
163164

src/main/java/ru/mystamps/web/controller/SeriesController.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ public String searchSeriesByCatalog(
457457
return "redirect:" + Url.INDEX_PAGE;
458458
}
459459

460-
// @todo #769 Support search by Zagorski number
460+
// @todo #776 Add integration tests for search series by Zagorski number
461461
// @todo #770 Support search by Solovyov number
462462
String lang = LocaleUtils.getLanguageOrNull(userLocale);
463463
List<SeriesInfoDto> series;
@@ -474,6 +474,9 @@ public String searchSeriesByCatalog(
474474
case "gibbons":
475475
series = seriesService.findByGibbonsNumber(catalogNumber, lang);
476476
break;
477+
case "zagorski":
478+
series = seriesService.findByZagorskiNumber(catalogNumber, lang);
479+
break;
477480
default:
478481
series = Collections.emptyList();
479482
break;

src/main/java/ru/mystamps/web/service/SeriesService.java

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public interface SeriesService {
4646
List<SeriesInfoDto> findByScottNumber(String scottNumberCode, String lang);
4747
List<SeriesInfoDto> findByYvertNumber(String yvertNumberCode, String lang);
4848
List<SeriesInfoDto> findByGibbonsNumber(String gibbonsNumberCode, String lang);
49+
List<SeriesInfoDto> findByZagorskiNumber(String zagorskiCatalogNumber, String lang);
4950

5051
List<SeriesInfoDto> findByCategorySlug(String slug, String lang);
5152
List<SeriesInfoDto> findByCountrySlug(String slug, String lang);

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

+7
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,13 @@ public List<SeriesInfoDto> findByGibbonsNumber(String gibbonsNumberCode, String
271271
return findByCatalogNumber(gibbonsCatalogService, gibbonsNumberCode, lang);
272272
}
273273

274+
// @todo #776 SeriesServiceImpl.findByZagorskiNumber(): add unit tests
275+
@Override
276+
@Transactional(readOnly = true)
277+
public List<SeriesInfoDto> findByZagorskiNumber(String zagorskiNumberCode, String lang) {
278+
return findByCatalogNumber(zagorskiCatalogService, zagorskiNumberCode, lang);
279+
}
280+
274281
@Override
275282
@Transactional(readOnly = true)
276283
public List<SeriesInfoDto> findByCategorySlug(String slug, String lang) {

src/main/resources/sql/stamps_catalog_dao_queries.properties

+7
Original file line numberDiff line numberDiff line change
@@ -205,3 +205,10 @@ SELECT sgc.series_id AS series_id \
205205
JOIN gibbons_catalog mc \
206206
ON mc.id = sgc.gibbons_id \
207207
WHERE mc.code = :number
208+
209+
series_zagorski.find_series_ids_by_number = \
210+
SELECT szc.series_id AS series_id \
211+
FROM series_zagorski_catalog szc \
212+
JOIN zagorski_catalog zc \
213+
ON zc.id = szc.zagorski_id \
214+
WHERE zc.code = :number

src/main/webapp/WEB-INF/views/site/index.html

+1
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ <h4 class="panel-title" th:text="#{t_search_by_catalog}">Search by catalog</h4>
253253
<option value="scott" th:text="#{t_scott}">Scott</option>
254254
<option value="yvert" th:text="#{t_yvert}">Yvert</option>
255255
<option value="gibbons" th:text="#{t_sg}">Gibbons</option>
256+
<option value="zagorski" th:text="#{t_zagorski}">Zagorski</option>
256257
</select>
257258
</div>
258259
<div class="form-group">

0 commit comments

Comments
 (0)