Skip to content

Commit d6cf190

Browse files
authored
chore(docs/decisions-log.md): document a workaround for Liquibase bug
Relate to #1549 [skip ci]
1 parent f3c2e20 commit d6cf190

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/decisions-log.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
| Date/Type | Description |
44
| --------- | ----------- |
5-
| 10.11.2021 Workaround | [php-coder/mystamps#1549](https://github.com/php-coder/mystamps/issues/1549): During update of **Liquibase** from 4.5.0 to 4.6.1 the bug has been faced -- the migration `0.4/2017-05-29--test_image.xml` has started to fail with error `BLOB resource not found: /test/test.png`. I postponed this update and filled a bug report to upstream. Bug: [liquibase/liquibase#2200](https://github.com/liquibase/liquibase/issues/2200) |
5+
| 10.11.2021 Workaround | [php-coder/mystamps#1549](https://github.com/php-coder/mystamps/issues/1549): During update of **Liquibase** from 4.5.0 to 4.6.1 the bug has been faced -- the migration `0.4/2017-05-29--test_image.xml` has started to fail with error `BLOB resource not found: /test/test.png`. I postponed this update and filled a bug report to upstream. Bug: [liquibase/liquibase#2200](https://github.com/liquibase/liquibase/issues/2200)<br />UPDATE(22.01.2022): in [f3c2e20d](https://github.com/php-coder/mystamps/commit/f3c2e20d1ba78703f53b6b090bfe7f7257e34a04) I have updated Liquibase to the latest version and also I applied a workaround by specifying a relative path instead of an absolute one. The future of the bug report isn't clear at this moment: it's definitely broke the backward compatibility and even a workaround requires us to modify the existing migration (that we mustn't do! but we can as this particular migration is used only by tests). From another hand, this change was made intentionally and it might stay with us forever |
66
| 02.07.2021 Workaround | Enablement of `GuardLogStatement` in **PMD** led to a few false positives when we concatenate constant string literals. This should be fixed in PMD >= 6.36.0 but until we have this version (see [php-coder/mystamps#1250](https://github.com/php-coder/mystamps/issues/1250)), I suppressed violations manually. Bug: [pmd/pmd#957](https://github.com/pmd/pmd/issues/957) Commits: [0b135cb4](https://github.com/php-coder/mystamps/commit/0b135cb41f2da6d5ffc6570acf0ae68db35295f7) |
77
| 02.07.2021 Workaround | [php-coder/mystamps#1536](https://github.com/php-coder/mystamps/issues/1536): `pip install robotframework-lint` has started to fail in TravisCI because one of the transitive dependencies (**robotframework-lint** -> robotframework -> ruamel.yaml.clib 0.2.4) requires at least Python 3.5 In order to unbreak the builds, I pinned the version of `robotframework` but it wasn't enough. Then I pinned the version of **ruamel.yaml.clib** to the latest worked version 0.2.2 Commits: [6c0180cb](https://github.com/php-coder/mystamps/commit/6c0180cb8c90df0d8239b123094ac7d9dd7d29f0), [8447ddb2](https://github.com/php-coder/mystamps/commit/8447ddb2f4944906a97619c9964afff3e2ff7842), [e6186331](https://github.com/php-coder/mystamps/commit/e61863319fdef76417f0e1a31b430aad10226748) |
88
| 09.01.2021 Decision | [php-coder/mystamps#1495](https://github.com/php-coder/mystamps/issues/1495): Let's move **generated images** for the diagrams to the separate branch (`generated-assets`). Later we can apply this approach for other generated content (reports, for example). Pros: it reduces a disk space/repository size because we always hold only the latest version of the images. We will use force-push for rewriting data. Cons: it makes diagram update (especially with PRs) a little more complex because it requires 2 commits (PRs). Commits: [6e7e149f](https://github.com/php-coder/mystamps/commit/6e7e149f84756a6fd817dc23e6e80c145783c784) |

0 commit comments

Comments
 (0)